You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/01/14 05:02:36 UTC
[GitHub] [incubator-tubemq] Technoboy- opened a new pull request #11:
correct DefaultLoadBalancer#balance rejGroupClientINfoMap ->
rejGroupClientInfoMap
Technoboy- opened a new pull request #11: correct DefaultLoadBalancer#balance rejGroupClientINfoMap -> rejGroupClientInfoMap
URL: https://github.com/apache/incubator-tubemq/pull/11
https://issues.apache.org/jira/browse/TUBEMQ-20
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] TisonKun merged pull request #11: correct
DefaultLoadBalancer#balance rejGroupClientINfoMap -> rejGroupClientInfoMap
Posted by GitBox <gi...@apache.org>.
TisonKun merged pull request #11: correct DefaultLoadBalancer#balance rejGroupClientINfoMap -> rejGroupClientInfoMap
URL: https://github.com/apache/incubator-tubemq/pull/11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] TisonKun commented on issue #11: [TUBEMQ-20]
Correct DefaultLoadBalancer#balance parameter
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #11: [TUBEMQ-20] Correct DefaultLoadBalancer#balance parameter
URL: https://github.com/apache/incubator-tubemq/pull/11#issuecomment-574462748
Yes I second by @gosonzhang . This time I help with squash and merge but @Technoboy- you should have taken the work by yourself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] gosonzhang commented on issue #11: correct
DefaultLoadBalancer#balance rejGroupClientINfoMap -> rejGroupClientInfoMap
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on issue #11: correct DefaultLoadBalancer#balance rejGroupClientINfoMap -> rejGroupClientInfoMap
URL: https://github.com/apache/incubator-tubemq/pull/11#issuecomment-574462514
@Technoboy-, before you mention PR, you need to update the integration based on the master‘s latest code. I found that many accepted contents are included again in this PR, such as 81f9350, 30d77ff, ee99d06 have been integrated, which will make the committer very confused，Which one was realy modified this time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] TisonKun commented on issue #11: [TUBEMQ-20]
Correct DefaultLoadBalancer#balance parameter
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #11: [TUBEMQ-20] Correct DefaultLoadBalancer#balance parameter
URL: https://github.com/apache/incubator-tubemq/pull/11#issuecomment-574463021
Another problem is that you'd better keep the title & commit log with the format `[TUBEMQ-XXX][optional component] ...`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] Technoboy- commented on issue #11: [TUBEMQ-20]
Correct DefaultLoadBalancer#balance parameter
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #11: [TUBEMQ-20] Correct DefaultLoadBalancer#balance parameter
URL: https://github.com/apache/incubator-tubemq/pull/11#issuecomment-574463954
> Another problem is that you'd better keep the title & commit log with the format `[TUBEMQ-XXX][optional component] ...`.
ok, forgot to comment on commit log
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] Technoboy- commented on issue #11: correct
DefaultLoadBalancer#balance rejGroupClientINfoMap -> rejGroupClientInfoMap
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #11: correct DefaultLoadBalancer#balance rejGroupClientINfoMap -> rejGroupClientInfoMap
URL: https://github.com/apache/incubator-tubemq/pull/11#issuecomment-574459774
@TisonKun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] Technoboy- commented on issue #11: [TUBEMQ-20]
Correct DefaultLoadBalancer#balance parameter
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #11: [TUBEMQ-20] Correct DefaultLoadBalancer#balance parameter
URL: https://github.com/apache/incubator-tubemq/pull/11#issuecomment-574463715
@TisonKun
> @Technoboy-, before you mention PR, you need to update the integration based on the master‘s latest code. I found that many accepted contents are included again in this PR, such as [81f9350](https://github.com/apache/incubator-tubemq/commit/81f9350d355ad3b788c15c0ae254b822cb983849), [30d77ff](https://github.com/apache/incubator-tubemq/commit/30d77ffded6624f53948285d8e897424237dee9e), [ee99d06](https://github.com/apache/incubator-tubemq/commit/ee99d06abec9505a70232d57a7c692f2e53e1472) have been integrated, which will make the committer very confused，Which one was realy modified this time?
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] TisonKun edited a comment on issue #11:
[TUBEMQ-20] Correct DefaultLoadBalancer#balance parameter
Posted by GitBox <gi...@apache.org>.
TisonKun edited a comment on issue #11: [TUBEMQ-20] Correct DefaultLoadBalancer#balance parameter
URL: https://github.com/apache/incubator-tubemq/pull/11#issuecomment-574462748
Yes I second @gosonzhang . This time I help with squash and merge but @Technoboy- you should have taken the work by yourself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services