You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2014/03/27 07:55:26 UTC
Review Request 19717: [Windows] enabled the SSL key generation part in
windows installer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19717/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6290
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6290
Repository: cloudstack-git
Description
-------
Added the functionality to the installer to be able to generate SSL keys for the first time when we are installing on windows.
Diffs
-----
scripts/common/keys/ssl-keys.py PRE-CREATION
scripts/installer/windows/acs.wxs adb2b6c
Diff: https://reviews.apache.org/r/19717/diff/
Testing
-------
Tested on windows 2008R2 server environment to make sure cloud.keystore is getting generated at desired place.
Thanks,
Damodar Reddy Talakanti
Re: Review Request 19717: [Windows] enabled the SSL key generation part in
windows installer
Posted by Abhinandan Prateek <ap...@apache.org>.
> On March 27, 2014, 10:23 a.m., Abhinandan Prateek wrote:
> > It depends on pre-installed Java. DO we check early on in the installer if java SDK is installed ?
>
> Damodar Reddy Talakanti wrote:
> Yes if JAVA_HOME is not set the installation will fail. Probably later, if possible I will check registry instead of relying on JAVA_HOME environment variable.
Please, file a bug for that.
- Abhinandan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19717/#review38712
-----------------------------------------------------------
On March 27, 2014, 6:55 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19717/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 6:55 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6290
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6290
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added the functionality to the installer to be able to generate SSL keys for the first time when we are installing on windows.
>
>
> Diffs
> -----
>
> scripts/common/keys/ssl-keys.py PRE-CREATION
> scripts/installer/windows/acs.wxs adb2b6c
>
> Diff: https://reviews.apache.org/r/19717/diff/
>
>
> Testing
> -------
>
> Tested on windows 2008R2 server environment to make sure cloud.keystore is getting generated at desired place.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 19717: [Windows] enabled the SSL key generation part in
windows installer
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
> On March 27, 2014, 10:23 a.m., Abhinandan Prateek wrote:
> > It depends on pre-installed Java. DO we check early on in the installer if java SDK is installed ?
Yes if JAVA_HOME is not set the installation will fail. Probably later, if possible I will check registry instead of relying on JAVA_HOME environment variable.
- Damodar Reddy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19717/#review38712
-----------------------------------------------------------
On March 27, 2014, 6:55 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19717/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 6:55 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6290
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6290
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added the functionality to the installer to be able to generate SSL keys for the first time when we are installing on windows.
>
>
> Diffs
> -----
>
> scripts/common/keys/ssl-keys.py PRE-CREATION
> scripts/installer/windows/acs.wxs adb2b6c
>
> Diff: https://reviews.apache.org/r/19717/diff/
>
>
> Testing
> -------
>
> Tested on windows 2008R2 server environment to make sure cloud.keystore is getting generated at desired place.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 19717: [Windows] enabled the SSL key generation part in
windows installer
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
> On March 27, 2014, 10:23 a.m., Abhinandan Prateek wrote:
> > It depends on pre-installed Java. DO we check early on in the installer if java SDK is installed ?
>
> Damodar Reddy Talakanti wrote:
> Yes if JAVA_HOME is not set the installation will fail. Probably later, if possible I will check registry instead of relying on JAVA_HOME environment variable.
>
> Abhinandan Prateek wrote:
> Please, file a bug for that.
created a defect for this at https://issues.apache.org/jira/browse/CLOUDSTACK-6291
- Damodar Reddy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19717/#review38712
-----------------------------------------------------------
On March 27, 2014, 6:55 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19717/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 6:55 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6290
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6290
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added the functionality to the installer to be able to generate SSL keys for the first time when we are installing on windows.
>
>
> Diffs
> -----
>
> scripts/common/keys/ssl-keys.py PRE-CREATION
> scripts/installer/windows/acs.wxs adb2b6c
>
> Diff: https://reviews.apache.org/r/19717/diff/
>
>
> Testing
> -------
>
> Tested on windows 2008R2 server environment to make sure cloud.keystore is getting generated at desired place.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 19717: [Windows] enabled the SSL key generation part in
windows installer
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19717/#review38712
-----------------------------------------------------------
It depends on pre-installed Java. DO we check early on in the installer if java SDK is installed ?
- Abhinandan Prateek
On March 27, 2014, 6:55 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19717/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 6:55 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6290
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6290
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added the functionality to the installer to be able to generate SSL keys for the first time when we are installing on windows.
>
>
> Diffs
> -----
>
> scripts/common/keys/ssl-keys.py PRE-CREATION
> scripts/installer/windows/acs.wxs adb2b6c
>
> Diff: https://reviews.apache.org/r/19717/diff/
>
>
> Testing
> -------
>
> Tested on windows 2008R2 server environment to make sure cloud.keystore is getting generated at desired place.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 19717: [Windows] enabled the SSL key generation part in
windows installer
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19717/#review38715
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On March 27, 2014, 6:55 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19717/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 6:55 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6290
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6290
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added the functionality to the installer to be able to generate SSL keys for the first time when we are installing on windows.
>
>
> Diffs
> -----
>
> scripts/common/keys/ssl-keys.py PRE-CREATION
> scripts/installer/windows/acs.wxs adb2b6c
>
> Diff: https://reviews.apache.org/r/19717/diff/
>
>
> Testing
> -------
>
> Tested on windows 2008R2 server environment to make sure cloud.keystore is getting generated at desired place.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>