You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2025/05/09 07:17:27 UTC
[PR] [SPARK-52053][PYTHON][TESTS] Enable test_job_cancellation and its parity test [spark]
zhengruifeng opened a new pull request, #50845:
URL: https://github.com/apache/spark/pull/50845
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Enable test_job_cancellation and its parity test
### Why are the changes needed?
test coverage
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52053][PYTHON][TESTS] Enable test_job_cancellation and its parity test [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #50845:
URL: https://github.com/apache/spark/pull/50845#discussion_r2081080915
##########
python/pyspark/sql/tests/test_job_cancellation.py:
##########
@@ -166,6 +166,7 @@ def get_outer_local_prop():
self.assertEqual(first, {"a", "b"})
self.assertEqual(second, {"a", "b", "c"})
+ @unittest.skip("SPARK-52054: Should enable this test")
Review Comment:
cc @itholic @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52053][PYTHON][TESTS] Enable test_job_cancellation and its parity test [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #50845: [SPARK-52053][PYTHON][TESTS] Enable test_job_cancellation and its parity test
URL: https://github.com/apache/spark/pull/50845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52053][PYTHON][TESTS] Enable test_job_cancellation and its parity test [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #50845:
URL: https://github.com/apache/spark/pull/50845#discussion_r2081080568
##########
python/pyspark/sql/tests/test_job_cancellation.py:
##########
@@ -166,6 +166,7 @@ def get_outer_local_prop():
self.assertEqual(first, {"a", "b"})
self.assertEqual(second, {"a", "b", "c"})
+ @unittest.skip("SPARK-52054: Should enable this test")
Review Comment:
fails with
```
======================================================================
FAIL [44.903s]: test_interrupt_tag (pyspark.sql.tests.test_job_cancellation.JobCancellationTests.test_interrupt_tag)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/__w/spark/spark/python/pyspark/sql/tests/test_job_cancellation.py", line 171, in test_interrupt_tag
self.check_job_cancellation(
File "/__w/spark/spark/python/pyspark/sql/tests/test_job_cancellation.py", line 125, in check_job_cancellation
self.assertTrue(
AssertionError: False is not true : Thread 0: Job in group A was not cancelled.
----------------------------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52053][PYTHON][TESTS] Enable test_job_cancellation and its parity test [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #50845:
URL: https://github.com/apache/spark/pull/50845#issuecomment-2865896210
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org