You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@juneau.apache.org by James Bognar <ja...@salesforce.com> on 2016/09/04 17:59:51 UTC
Apache-rat tool errors fixed.
I've fixed the issues found by the apache-rat tool. We should be clean
now.
I've updated the coding guidelines with the copyright statements for each
file type...
https://cwiki.apache.org/confluence/display/JUNEAU/Coding+guidelines
The rat tool still complains about "rat.txt" not containing a copyright.
I'm just going to ignore that one.
--
James Bognar
Re: Apache-rat tool errors fixed.
Posted by James Bognar <ja...@salesforce.com>.
Thanks John,
After adding the plugin declaration, it appears to be working now.
I also removed the Git/Jira/website links from the non-root pom files.
On Sun, Sep 4, 2016 at 7:36 PM, John D. Ament <jo...@apache.org> wrote:
> Here's an example config:
> https://github.com/apache/incubator-tamaya/blob/master/pom.xml#L596
>
> I suspect because we don't declare anything for rat, its not even taking
> the maven defaults, but that's just a hunch.
>
> John
>
> On Sun, Sep 4, 2016 at 6:49 PM James Bognar <ja...@salesforce.com>
> wrote:
>
> > I'm not sure why I would need to (or how to do that). It's complaining
> > about the *target/rat.txt* file that it itself is generating.
> >
> > On Sun, Sep 4, 2016 at 2:51 PM, John D. Ament <jo...@apache.org>
> > wrote:
> >
> > > On Sun, Sep 4, 2016 at 2:00 PM James Bognar <
> james.bognar@salesforce.com
> > >
> > > wrote:
> > >
> > > > I've fixed the issues found by the apache-rat tool. We should be
> clean
> > > > now.
> > > >
> > > > I've updated the coding guidelines with the copyright statements for
> > each
> > > > file type...
> > > > https://cwiki.apache.org/confluence/display/JUNEAU/Coding+guidelines
> > > >
> > > > The rat tool still complains about "rat.txt" not containing a
> > copyright.
> > > > I'm just going to ignore that one.
> > > >
> > >
> > > Did you add it to the ignore section in the pom file?
> > >
> > >
> > > >
> > > >
> > > > --
> > > > James Bognar
> > > >
> > >
> >
> >
> >
> > --
> > James Bognar
> >
>
--
James Bognar
Re: Apache-rat tool errors fixed.
Posted by "John D. Ament" <jo...@apache.org>.
Here's an example config:
https://github.com/apache/incubator-tamaya/blob/master/pom.xml#L596
I suspect because we don't declare anything for rat, its not even taking
the maven defaults, but that's just a hunch.
John
On Sun, Sep 4, 2016 at 6:49 PM James Bognar <ja...@salesforce.com>
wrote:
> I'm not sure why I would need to (or how to do that). It's complaining
> about the *target/rat.txt* file that it itself is generating.
>
> On Sun, Sep 4, 2016 at 2:51 PM, John D. Ament <jo...@apache.org>
> wrote:
>
> > On Sun, Sep 4, 2016 at 2:00 PM James Bognar <james.bognar@salesforce.com
> >
> > wrote:
> >
> > > I've fixed the issues found by the apache-rat tool. We should be clean
> > > now.
> > >
> > > I've updated the coding guidelines with the copyright statements for
> each
> > > file type...
> > > https://cwiki.apache.org/confluence/display/JUNEAU/Coding+guidelines
> > >
> > > The rat tool still complains about "rat.txt" not containing a
> copyright.
> > > I'm just going to ignore that one.
> > >
> >
> > Did you add it to the ignore section in the pom file?
> >
> >
> > >
> > >
> > > --
> > > James Bognar
> > >
> >
>
>
>
> --
> James Bognar
>
Re: Apache-rat tool errors fixed.
Posted by James Bognar <ja...@salesforce.com>.
I'm not sure why I would need to (or how to do that). It's complaining
about the *target/rat.txt* file that it itself is generating.
On Sun, Sep 4, 2016 at 2:51 PM, John D. Ament <jo...@apache.org> wrote:
> On Sun, Sep 4, 2016 at 2:00 PM James Bognar <ja...@salesforce.com>
> wrote:
>
> > I've fixed the issues found by the apache-rat tool. We should be clean
> > now.
> >
> > I've updated the coding guidelines with the copyright statements for each
> > file type...
> > https://cwiki.apache.org/confluence/display/JUNEAU/Coding+guidelines
> >
> > The rat tool still complains about "rat.txt" not containing a copyright.
> > I'm just going to ignore that one.
> >
>
> Did you add it to the ignore section in the pom file?
>
>
> >
> >
> > --
> > James Bognar
> >
>
--
James Bognar
Re: Apache-rat tool errors fixed.
Posted by "John D. Ament" <jo...@apache.org>.
On Sun, Sep 4, 2016 at 2:00 PM James Bognar <ja...@salesforce.com>
wrote:
> I've fixed the issues found by the apache-rat tool. We should be clean
> now.
>
> I've updated the coding guidelines with the copyright statements for each
> file type...
> https://cwiki.apache.org/confluence/display/JUNEAU/Coding+guidelines
>
> The rat tool still complains about "rat.txt" not containing a copyright.
> I'm just going to ignore that one.
>
Did you add it to the ignore section in the pom file?
>
>
> --
> James Bognar
>