[GitHub] [zookeeper] cuibo01 commented on a change in pull request #1736: [ZOOKEEPER-4345]Avoid NoSunchMethodException caused by shaded

[GitBox <gi...@apache.org>]

cuibo01 commented on a change in pull request #1736:
URL: https://github.com/apache/zookeeper/pull/1736#discussion_r684716138



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java
##########
@@ -3031,6 +3031,13 @@ private ClientCnxnSocket getClientCnxnSocket() throws IOException {
         if (clientCnxnSocketName == null) {
             clientCnxnSocketName = ClientCnxnSocketNIO.class.getName();
         }
+
+        if (clientCnxnSocketName.equals(ClientCnxnSocketNetty.class.getSimpleName())) {

Review comment:
       thx for your review
   if jvm set -Dzookeeper.clientCnxnSocket=ClientCnxnSocketNetty or ClientCnxnSocketNIO，
   in zookeeper jar，clientCnxnSocketName is org.apache.zookeeper.ClientCnxnSocketNetty  or org.apache.zookeeper.ClientCnxnSocketNIO
   and in shaded zookeeper jar, clientCnxnSocketName is ${shaded.prefix}.org.apache.zookeeper.ClientCnxnSocketNetty or ${shaded.prefix}.org.apache.zookeeper.ClientCnxnSocketNIO
   clientCnxnSocketName value is always correct.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org