You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/08 10:28:42 UTC
[GitHub] [cloudstack] mib1185 opened a new pull request #4574: correct db-schema update 4.14.0 to 4.15.0
mib1185 opened a new pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574
### Description
Correct copy&paste issue from lines
https://github.com/apache/cloudstack/blob/c82688a3559929fafa388192b949f4136b5d3d27/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L782
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [x] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4574: db-schema update 4.15.0 to 4.15.1: correct some guest-os namings
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#discussion_r592133507
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -19,3 +19,7 @@
-- Schema upgrade from 4.15.0.0 to 4.15.1.0
--;
+-- Correct guest OS names
+UPDATE `cloud`.`guest_os` SET display_name='Fedora Linux (32 bit)' WHERE id=320;
+UPDATE `cloud`.`guest_os` SET display_name='Mandriva Linux (32 bit)' WHERE id=323;
+UPDATE `cloud`.`guest_os` SET display_name='OpenSUSE Linux (32 bit)' WHERE id=327;
Review comment:
ID 327 in DB is `SCO OpenServer 6 `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 edited a comment on pull request #4574: db-schema update 4.15.0 to 4.15.1: correct some guest-os namings
Posted by GitBox <gi...@apache.org>.
mib1185 edited a comment on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-766715842
@shwstppr conflicts are resolved and rebase to current `master` is done, or do you mean, i should set this PR again branch `4.15` instead of `master` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #4574: db-schema update 4.15.0 to 4.15.1: correct some guest-os namings
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-766723180
@shwstppr now I get it ... rebase to `4.15` is done and PR is set again branch `4.15`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-766715842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#discussion_r553869223
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -801,9 +801,9 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '6.7.3', 'opensuse64Guest', 326, now(), 0);
--- Add SCO OpenServer 6 as support guest os
-INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (327, UUID(), 7, 'SCO OpenServer 6', now());
--- SCO OpenServer 6 VMWare guest os mapping
+-- Add OpenSUSE Linux as support guest os
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (327, UUID(), 7, 'OpenSUSE Linux', now());
+-- OpenSUSE Linux VMWare guest os mapping
Review comment:
"opensuseGuest" vmware mapping refers to "SUSE openSUSE (32-bit), so I think its better to keep 32bit information in the display name. 64bit has different name in vmware "opensuse64Guest" so its good to differentiate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#discussion_r553869223
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -801,9 +801,9 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '6.7.3', 'opensuse64Guest', 326, now(), 0);
--- Add SCO OpenServer 6 as support guest os
-INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (327, UUID(), 7, 'SCO OpenServer 6', now());
--- SCO OpenServer 6 VMWare guest os mapping
+-- Add OpenSUSE Linux as support guest os
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (327, UUID(), 7, 'OpenSUSE Linux', now());
+-- OpenSUSE Linux VMWare guest os mapping
Review comment:
"opensuseGuest" vmware mapping refers to "SUSE openSUSE (32-bit), so I think its better to keep 32bit information in the display name. 64bit has different name in vmware "opensuse64Guest" so its good to differentiate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 edited a comment on pull request #4574: db-schema update 4.15.0 to 4.15.1: correct some guest-os namings
Posted by GitBox <gi...@apache.org>.
mib1185 edited a comment on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-766715842
@shwstppr conflicts are resolved and rebase to current `master` is done, or do you mean, i should set this PR again branch `4.15` instead of `master` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-762704925
@mib1185 since 4.15.0.0 is released and the records has been inserted into db, you need to use UPDATE instead of INSERT INTO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-766686293
@mib1185 can you please fix conflicts and rebase against 4.15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 edited a comment on pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
mib1185 edited a comment on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-762263535
@DaanHoogland yeah for sure, you are right. But to be honest, I'm not really familiar with the upgrade system and therefore would kindly ask for support to create a appropriate upgrade file. Will there be an 4.15.1 or is 4.16 targeted for this issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-766715842
@shwstppr conflicts are resolved and rebase to current `master` is done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4574: db-schema update 4.15.0 to 4.15.1: correct some guest-os namings
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#discussion_r592134122
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -19,3 +19,7 @@
-- Schema upgrade from 4.15.0.0 to 4.15.1.0
--;
+-- Correct guest OS names
+UPDATE `cloud`.`guest_os` SET display_name='Fedora Linux (32 bit)' WHERE id=320;
+UPDATE `cloud`.`guest_os` SET display_name='Mandriva Linux (32 bit)' WHERE id=323;
+UPDATE `cloud`.`guest_os` SET display_name='OpenSUSE Linux (32 bit)' WHERE id=327;
Review comment:
Nevermind the only mapping is that for opensuse/vmware:
```
mysql> select * from guest_os_hypervisor where guest_os_id=327;
+------+-----------------+---------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| id | hypervisor_type | guest_os_name | guest_os_id | hypervisor_version | uuid | created | removed | is_user_defined |
+------+-----------------+---------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| 7156 | VMware | opensuseGuest | 327 | 6.0 | 81c7f8a1-4b4d-11eb-8705-dca6322512d7 | 2020-12-31 09:49:42 | NULL | 0 |
| 7157 | VMware | opensuseGuest | 327 | 6.5 | 81c8b2d6-4b4d-11eb-8705-dca6322512d7 | 2020-12-31 09:49:42 | NULL | 0 |
| 7158 | VMware | opensuseGuest | 327 | 6.7 | 81c95b16-4b4d-11eb-8705-dca6322512d7 | 2020-12-31 09:49:42 | NULL | 0 |
| 7159 | VMware | opensuseGuest | 327 | 6.7.1 | 81ca26a0-4b4d-11eb-8705-dca6322512d7 | 2020-12-31 09:49:42 | NULL | 0 |
| 7160 | VMware | opensuseGuest | 327 | 6.7.2 | 81cadedc-4b4d-11eb-8705-dca6322512d7 | 2020-12-31 09:49:42 | NULL | 0 |
| 7161 | VMware | opensuseGuest | 327 | 6.7.3 | 81cbadad-4b4d-11eb-8705-dca6322512d7 | 2020-12-31 09:49:42 | NULL | 0 |
+------+-----------------+---------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
6 rows in set (0.00 sec)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4574: db-schema update 4.15.0 to 4.15.1: correct some guest-os namings
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-762239193
@mib1185 @harikrishna-patnala @RodrigoDLopez does it make sense to move this line to a newer upgrade file? 4.15.0.0 has been released already and we want to keep our fragile upgrade system as consistent as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-760158264
Hi,
I have added (32 Bit) where it is applicable. For 693, 739, 771 and 782 there are no different versions for 32 or 64 bit and therefor has no information about that added.
Source: https://vdc-download.vmware.com/vmwb-repository/dcr-public/da47f910-60ac-438b-8b9b-6122f4d14524/16b7274a-bf8b-4b4c-a05e-746f2aa93c8c/doc/vim.vm.GuestOsDescriptor.GuestOsIdentifier.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-763102959
@DaanHoogland I would limit it to "4.15.0.0 to 4.15.1.0", because adding it also to 4.14.1 will conflict with the the insert's in table `cloud.guest_os` during upgrade to 4.15.0.
I noticed that there is an `com.cloud.upgrade.dao` package still needed, but I hope, someone other will implement this 🤞 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-762701627
@mib1185 if you can make it idempotent it makes sense to put it in 4.14.0.0 to 4.14.1.0 and in 4.15.0.0 to 4.15.1.0. If that is too much work I'd leave it to only go to 4.15.1.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4574: db-schema update 4.15.0 to 4.15.1: correct some guest-os namings
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-766865506
@mib1185
this pr lgtm
one question, there are two "SCO OpenServer 5" (ids are 85 and 324).
do you know the difference and plan to change one of them as well ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on a change in pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
mib1185 commented on a change in pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#discussion_r553885547
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -801,9 +801,9 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '6.7.3', 'opensuse64Guest', 326, now(), 0);
--- Add SCO OpenServer 6 as support guest os
-INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (327, UUID(), 7, 'SCO OpenServer 6', now());
--- SCO OpenServer 6 VMWare guest os mapping
+-- Add OpenSUSE Linux as support guest os
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (327, UUID(), 7, 'OpenSUSE Linux', now());
+-- OpenSUSE Linux VMWare guest os mapping
Review comment:
I´m a little bit confused, because the behaviour of adding/not adding (32-bit) is inconsistent already in this single db-schema upgrade file - for example:
---
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L593
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L594
---
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L620
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L631
---
and opposite
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L718
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L729
---
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L749
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L760
So, what should I use as template?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4574: db-schema update 4.15.0 to 4.15.1: correct some guest-os namings
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-767352934
> @weizhouapache
> id 85 looks somehow strange - I gues it should be "other guest" instead of "SCO OpenServer 5" 🤔
>
> ```sql
> SELECT * FROM cloud.guest_os WHERE id=85;
> # id, category_id, name, uuid, display_name, created, removed, is_user_defined
> '85', '9', NULL, '78751473-935a-11ea-95f2-005056bb3ebd', 'SCO OpenServer 5', '2020-05-11 09:42:56', NULL, '0'
> ```
>
> ```sql
> SELECT * FROM cloud.guest_os_hypervisor WHERE guest_os_id=85;
> # id, hypervisor_type, guest_os_name, guest_os_id, hypervisor_version, uuid, created, removed, is_user_defined
> '202', 'VmWare', 'SCO OpenServer 5', '85', 'default', '07511bbc-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:56', NULL, '0'
> '1387', 'VMware', 'otherGuest', '85', '4.0', '0864ff31-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:58', NULL, '0'
> '1528', 'VMware', 'otherGuest', '85', '4.1', '0870b56f-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:58', NULL, '0'
> '1669', 'VMware', 'otherGuest', '85', '5.0', '087d1de5-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:58', NULL, '0'
> '1810', 'VMware', 'otherGuest', '85', '5.1', '0888ac46-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:58', NULL, '0'
> '1951', 'VMware', 'otherGuest', '85', '5.5', '0895bef6-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:58', NULL, '0'
> '2448', 'VMware', 'otherGuest', '85', '6.0', '0cf88f63-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:05', NULL, '0'
> '2889', 'VMware', 'otherGuest', '85', '6.5', '0f30e427-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:09', NULL, '0'
> '4822', 'VMware', 'otherGuest', '85', '6.7', '1169e8de-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:13', NULL, '0'
> '5077', 'VMware', 'otherGuest', '85', '6.7.1', '116b494b-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:13', NULL, '0'
> '5332', 'VMware', 'otherGuest', '85', '6.7.2', '116c801a-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:13', NULL, '0'
> '5587', 'VMware', 'otherGuest', '85', '6.7.3', '116dbb0a-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:13', NULL, '0'
> ```
@mib1185 thanks.
@nvazquez since you are author of commit 50ab1b2fbe84aa60d8d7adc12919bebc83b5e003, could you please look at the issue above ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #4574: db-schema update 4.15.0 to 4.15.1: correct some guest-os namings
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-766954085
@weizhouapache
id 85 looks somehow strange - I gues it should be "other guest" instead of "SCO OpenServer 5" 🤔
```sql
SELECT * FROM cloud.guest_os WHERE id=85;
# id, category_id, name, uuid, display_name, created, removed, is_user_defined
'85', '9', NULL, '78751473-935a-11ea-95f2-005056bb3ebd', 'SCO OpenServer 5', '2020-05-11 09:42:56', NULL, '0'
```
```sql
SELECT * FROM cloud.guest_os_hypervisor WHERE guest_os_id=85;
# id, hypervisor_type, guest_os_name, guest_os_id, hypervisor_version, uuid, created, removed, is_user_defined
'202', 'VmWare', 'SCO OpenServer 5', '85', 'default', '07511bbc-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:56', NULL, '0'
'1387', 'VMware', 'otherGuest', '85', '4.0', '0864ff31-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:58', NULL, '0'
'1528', 'VMware', 'otherGuest', '85', '4.1', '0870b56f-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:58', NULL, '0'
'1669', 'VMware', 'otherGuest', '85', '5.0', '087d1de5-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:58', NULL, '0'
'1810', 'VMware', 'otherGuest', '85', '5.1', '0888ac46-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:58', NULL, '0'
'1951', 'VMware', 'otherGuest', '85', '5.5', '0895bef6-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:58', NULL, '0'
'2448', 'VMware', 'otherGuest', '85', '6.0', '0cf88f63-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:05', NULL, '0'
'2889', 'VMware', 'otherGuest', '85', '6.5', '0f30e427-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:09', NULL, '0'
'4822', 'VMware', 'otherGuest', '85', '6.7', '1169e8de-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:13', NULL, '0'
'5077', 'VMware', 'otherGuest', '85', '6.7.1', '116b494b-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:13', NULL, '0'
'5332', 'VMware', 'otherGuest', '85', '6.7.2', '116c801a-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:13', NULL, '0'
'5587', 'VMware', 'otherGuest', '85', '6.7.3', '116dbb0a-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:13', NULL, '0'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-766686293
@mib1185 can you please fix conflicts and rebase against 4.15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on a change in pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
mib1185 commented on a change in pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#discussion_r553885547
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -801,9 +801,9 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '6.7.3', 'opensuse64Guest', 326, now(), 0);
--- Add SCO OpenServer 6 as support guest os
-INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (327, UUID(), 7, 'SCO OpenServer 6', now());
--- SCO OpenServer 6 VMWare guest os mapping
+-- Add OpenSUSE Linux as support guest os
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created) VALUES (327, UUID(), 7, 'OpenSUSE Linux', now());
+-- OpenSUSE Linux VMWare guest os mapping
Review comment:
I´m a little bit confused, because the behaviour of adding/not adding (32-bit) is inconsistent already in this single db-schema upgrade file - for example:
---
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L593
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L594
---
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L620
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L631
---
and opposite
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L718
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L729
---
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L749
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L760
So, what should I use as template?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-762263535
@DaanHoogland yeah for sure, you are right. But to be honest, I'm not really familiar with the upgrade system and therefore would kindly ask for support to create a appropriate upgrade file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4574: correct db-schema update 4.14.0 to 4.15.0
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-762767787
@mib1185 code changes looks good to me, as suggested please move out from 4.15.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4574: db-schema update 4.15.0 to 4.15.1: correct some guest-os namings
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-766865506
@mib1185
this pr lgtm
one question, there are two "SCO OpenServer 5" (ids are 85 and 324).
do you know the difference and plan to change one of them as well ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org