You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by hequn8128 <gi...@git.apache.org> on 2018/01/05 09:48:56 UTC

[GitHub] flink pull request #5244: [FLINK-8366] [table] Use Row instead of String as ...

GitHub user hequn8128 opened a pull request:

    https://github.com/apache/flink/pull/5244

    [FLINK-8366] [table] Use Row instead of String as key when process upsert results

    
    ## What is the purpose of the change
    
    This pr fix the bug in `TableSinkITCase.upsertResults()`. In `upsertResults()` function, we use String as key to upsert results. This will make (1,11) and (11,1) have the same key (i.e., 111).
    
    
    ## Brief change log
    
      - Use Row instead of String to avoid the String problem.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hequn8128/flink 8366

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5244
    
----
commit 259751257a5b4154d4b16b46c7fa38e25638a5ef
Author: 军长 <he...@...>
Date:   2018-01-05T08:53:31Z

    [FLINK-8366] [table] Use Row instead of String as key when process upsert results

----


---

[GitHub] flink issue #5244: [FLINK-8366] [table] Use Row instead of String as key whe...

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/5244
  
    Thanks for the fix @hequn8128!
    +1 to merge


---

[GitHub] flink pull request #5244: [FLINK-8366] [table] Use Row instead of String as ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5244


---

[GitHub] flink issue #5244: [FLINK-8366] [table] Use Row instead of String as key whe...

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/5244
  
    merging


---