You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/30 11:04:18 UTC
[GitHub] [hudi] wangxianghu opened a new pull request #2055: [HUDI-1253] Merge two TestHoodieSnapshotExporter in hudi-utilities
wangxianghu opened a new pull request #2055:
URL: https://github.com/apache/hudi/pull/2055
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*Merge two TestHoodieSnapshotExporter in hudi-utilities*
## Brief change log
*Currently, there are two classes named `TestHoodieSnapshotExporter`, we'd better rename one of them or merge them to one class.*
## Verify this pull request
This pull request is already covered by existing tests, such as *org.apache.hudi.utilities.functional.TestHoodieSnapshotExporter*.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #2055: [HUDI-1253] Merge two TestHoodieSnapshotExporter to one class
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #2055:
URL: https://github.com/apache/hudi/pull/2055#issuecomment-683501153
> Hi @wangxianghu thanks for the changes. The split was intended for distinguishing between unit test and functional tests. Please see this ticket https://issues.apache.org/jira/browse/HUDI-994
> When we use `@Tag("functional")` it means the whole test class will be included in a test suite to be run with `-Pfunctional-tests`. The class you deleted here is a pure unit test hence it'd better stay as is. We'll probably come up with a guide about testing here.
Hi, @xushiyan thanks for your explanation. closing this now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan edited a comment on pull request #2055: [HUDI-1253] Merge two TestHoodieSnapshotExporter to one class
Posted by GitBox <gi...@apache.org>.
xushiyan edited a comment on pull request #2055:
URL: https://github.com/apache/hudi/pull/2055#issuecomment-683446451
Hi @wangxianghu thanks for the changes. The split was intended for distinguishing between unit test and functional tests. Please see this ticket https://issues.apache.org/jira/browse/HUDI-994
When we use `@Tag("functional")` it means the whole test class will be included in a test suite to be run with `-Pfunctional-tests`. The class you deleted here is a pure unit test hence it'd better stay as is. We'll probably come up with a guide about testing here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu closed pull request #2055: [HUDI-1253] Merge two TestHoodieSnapshotExporter to one class
Posted by GitBox <gi...@apache.org>.
wangxianghu closed pull request #2055:
URL: https://github.com/apache/hudi/pull/2055
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #2055: [HUDI-1253] Merge two TestHoodieSnapshotExporter to one class
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #2055:
URL: https://github.com/apache/hudi/pull/2055#issuecomment-683446451
Hi @wangxianghu thanks for the changes. The split was intended for distinguishing between unit test and functional tests. Please see this ticket https://issues.apache.org/jira/browse/HUDI-994
When we use `@Tag("functional")` it means the whole test class will be included in a test suite to be run with `-Pfunctional-tests`. We'll probably come up with a guide about testing here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #2055: [HUDI-1253] Merge two TestHoodieSnapshotExporter in hudi-utilities
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #2055:
URL: https://github.com/apache/hudi/pull/2055#issuecomment-683406706
@yanghua @xushiyan please take a look when free
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org