You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streams.apache.org by sb...@apache.org on 2014/07/07 17:10:00 UTC

[4/5] git commit: PR 44 feedback

PR 44 feedback


Project: http://git-wip-us.apache.org/repos/asf/incubator-streams/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-streams/commit/738e7cac
Tree: http://git-wip-us.apache.org/repos/asf/incubator-streams/tree/738e7cac
Diff: http://git-wip-us.apache.org/repos/asf/incubator-streams/diff/738e7cac

Branch: refs/heads/master
Commit: 738e7cac5c307fcf6dfcd451a08826b6ba984a62
Parents: b1f94a6
Author: sblackmon <sb...@w2odigital.com>
Authored: Mon Jul 7 10:02:30 2014 -0500
Committer: sblackmon <sb...@w2odigital.com>
Committed: Mon Jul 7 10:02:30 2014 -0500

----------------------------------------------------------------------
 streams-contrib/streams-persist-elasticsearch/README.md     | 9 ---------
 .../apache/streams/elasticsearch/ElasticsearchQuery.java    | 4 +---
 2 files changed, 1 insertion(+), 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/738e7cac/streams-contrib/streams-persist-elasticsearch/README.md
----------------------------------------------------------------------
diff --git a/streams-contrib/streams-persist-elasticsearch/README.md b/streams-contrib/streams-persist-elasticsearch/README.md
index fbdf86c..c4182e4 100644
--- a/streams-contrib/streams-persist-elasticsearch/README.md
+++ b/streams-contrib/streams-persist-elasticsearch/README.md
@@ -36,12 +36,3 @@ Example writer configuration:
         "type": "destinationtype
     }
 
-For more examples, see:
-
-- [elasticsearch-backup](http://github.com/w2ogroup/streams-examples/tree/master/elasticsearch-backup)
-- [elasticsearch-reindex](http://github.com/w2ogroup/streams-examples/tree/master/elasticsearch-reindex)
-- [elasticsearch-restore](http://github.com/w2ogroup/streams-examples/tree/master/elasticsearch-restore)
-- [mongo-elasticsearch-index](https://github.com/w2ogroup/streams-examples/tree/master/mongo-elasticsearch-index)
-- [twitter-gardenhose-elasticsearch](https://github.com/w2ogroup/streams-examples/tree/master/twitter-gardenhose-elasticsearch)
-- [twitter-history-elasticsearch](https://github.com/w2ogroup/streams-examples/tree/master/twitter-history-elasticsearch)
-- [twitter-userstream-elasticsearch](https://github.com/w2ogroup/streams-examples/tree/master/twitter-userstream-elasticsearch)
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/738e7cac/streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchQuery.java
----------------------------------------------------------------------
diff --git a/streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchQuery.java b/streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchQuery.java
index 55064d3..fbc62c4 100644
--- a/streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchQuery.java
+++ b/streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchQuery.java
@@ -146,8 +146,7 @@ public class ElasticsearchQuery implements Iterable<SearchHit>, Iterator<SearchH
                     search = search.setExtraSource(searchJson);
 
                 } catch (JsonProcessingException e) {
-                    LOGGER.warn("Could not apply _search supplied by config");
-                    e.printStackTrace();
+                    LOGGER.warn("Could not apply _search supplied by config", e.getMessage());
                 }
 
                 LOGGER.debug("Search Source is now " + search.toString());
@@ -239,7 +238,6 @@ public class ElasticsearchQuery implements Iterable<SearchHit>, Iterator<SearchH
                 totalRead += 1;
             }
         } catch (Exception e) {
-            e.printStackTrace();
             LOGGER.error("Unexpected scrolling error: {}", e.getMessage());
             scrollPositionInScroll = -1;
             next = null;