[jira] [Commented] (HADOOP-19394) S3A Analytics Accelerator: vector IO support

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-19394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956066#comment-17956066 ] 

ASF GitHub Bot commented on HADOOP-19394:
-----------------------------------------

steveloughran commented on code in PR #7720:
URL: https://github.com/apache/hadoop/pull/7720#discussion_r2123611219


##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/contract/s3a/ITestS3AContractAnalyticsStreamVectoredRead.java:
##########
@@ -19,11 +19,21 @@
 package org.apache.hadoop.fs.contract.s3a;
 
 import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FSDataInputStream;
+import org.apache.hadoop.fs.FileRange;
 import org.apache.hadoop.fs.contract.AbstractContractVectoredReadTest;
 import org.apache.hadoop.fs.contract.AbstractFSContract;
+import org.apache.hadoop.fs.contract.ContractTestUtils;
+import org.apache.hadoop.fs.statistics.IOStatistics;
+import org.apache.hadoop.fs.statistics.StreamStatisticNames;
+
+import org.junit.Test;

Review Comment:
   nit: ordering





> S3A Analytics Accelerator: vector IO support
> --------------------------------------------
>
>                 Key: HADOOP-19394
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19394
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.4.1
>            Reporter: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>
> Add vector IO support for analytics accelerator stream
> Three stages
> # pull up s3a input stream to work with all ObjectInputStreams; do its own fetching independent of the analytics stream
> # provide info to stream of fetches having taken place (remove from cache, cancel prefetch)
> full integration
> * return a range from cache if present
> * append to the block retrieval callback if a prefetch is in progress
> * only do merge + new request if the range cannot be satisifed entirely from cached data
> Out of scope: handling case where part of a range is in cache/retrieval. Too complicated and so prone to problems. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org