[GitHub] HanumathRao commented on a change in pull request #1426: DRILL-6671: Multi level lateral unnest join is throwing an exception …

[GitBox <gi...@apache.org>]

HanumathRao commented on a change in pull request #1426: DRILL-6671: Multi level lateral unnest join is throwing an exception …
URL: https://github.com/apache/drill/pull/1426#discussion_r208649747
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/lateraljoin/TestE2EUnnestAndLateral.java
 ##########
 @@ -169,13 +169,31 @@ public void testLeftLateral_WithFilterAndLimitInSubQuery() throws Exception {
   @Test
   public void testMultiUnnestAtSameLevel() throws Exception {
     String Sql = "EXPLAIN PLAN FOR SELECT customer.c_name, customer.c_address, U1.order_id, U1.order_amt," +
 
 Review comment:
   @vvysotskyi This is an existing testcase. I just want to keep it intact. I cannot remove the EXPLAIN PLAN and use it for executing the query because this query will result in an execution error (unnest is not supported for non list types) and this is the right behaviour. For testing the usecase of this PR an additional testcase has been introduced which also tests for the correctness of the result.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services