You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/18 07:30:18 UTC
[GitHub] [iceberg] kbendick opened a new pull request #3915: Build: Fix -r option in source-release
kbendick opened a new pull request #3915:
URL: https://github.com/apache/iceberg/pull/3915
The `-r` flag, to specfy the release candidate number, was removed in a PR to fix `-g` flag. https://github.com/apache/iceberg/pull/3824
I've added it back in, alongside the `-g` flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #3915: Build: Fix source-release script to run anywhere automated and add validation that remote git repo exists
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #3915:
URL: https://github.com/apache/iceberg/pull/3915#discussion_r786475468
##########
File path: dev/source-release.sh
##########
@@ -38,7 +38,7 @@ usage () {
# Default repository remote name
remote="apache"
Review comment:
In the PR that updated `-g`, the default remote repository was changed from `origin` to `apache`.
I know many people use `apache` for their upstream project name.
But, I believe we used `origin` for the remote name as this is possibly expected to run on ASF infra / github runners, where the origin repository is `origin`.
If this runs on more than a PMCs laptop, then we should keep it as `origin` but add in the flag. This can be done in a follow up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3915: Build: Fix source-release script to run anywhere automated and add validation that remote git repo exists
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3915:
URL: https://github.com/apache/iceberg/pull/3915#issuecomment-1015943555
Thanks, @kbendick!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #3915: Build: Fix source-release script to run anywhere automated and add validation that remote git repo exists
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #3915:
URL: https://github.com/apache/iceberg/pull/3915#discussion_r786502468
##########
File path: dev/source-release.sh
##########
@@ -68,6 +69,11 @@ if [ -z "$version" ] || [ -z "$rc" ]; then
usage
fi
+if ! git ls-remote --quiet --exit-code "$remote"; then
Review comment:
TODO - The error logs still print out, so need to redirect error stream to /dev/null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #3915: Build: Fix -r option in source-release for specifying the build RC candidate number
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #3915:
URL: https://github.com/apache/iceberg/pull/3915#issuecomment-1015141028
Nevermind, I just noticed that `r` is earlier on in the arguments list. I thought it had been removed.
I'm going to change this to update back to `origin`. We can close it if we don't believe this runs on any GH runners or anywhere but a PMC / release managers local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #3915: Build: Fix source-release script to run anywhere automated and add validation that remote git repo exists
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3915:
URL: https://github.com/apache/iceberg/pull/3915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #3915: Build: Fix -r option in source-release for specifying the build RC candidate number
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #3915:
URL: https://github.com/apache/iceberg/pull/3915#discussion_r786475468
##########
File path: dev/source-release.sh
##########
@@ -38,7 +38,7 @@ usage () {
# Default repository remote name
remote="apache"
Review comment:
In the PR that updated `-g`, the default remote repository was changed from `origin` to `apache`.
I know many people use `apache` for their upstream project name.
But, I believe we used `origin` for the remote name as this is possibly expected to run on ASF infra / github runners, where the origin repository is `origin`.
If this runs on more than a PMCs laptop, then we should keep it as `origin` but add in the flag. This can be done in a follow up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #3915: Build: Fix source-release script to run anywhere automated and add validation that remote git repo exists
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #3915:
URL: https://github.com/apache/iceberg/pull/3915#discussion_r786502468
##########
File path: dev/source-release.sh
##########
@@ -68,6 +69,11 @@ if [ -z "$version" ] || [ -z "$rc" ]; then
usage
fi
+if ! git ls-remote --quiet --exit-code "$remote"; then
Review comment:
~~TODO - The error logs still print out, so need to redirect error stream to /dev/null.~~
Update: I have tested this and it logs stdout and stderr to /dev/null now (so just the log in the `echo` statement or nothing at all).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #3915: Build: Fix source-release script to run anywhere automated and add validation that remote git repo exists
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #3915:
URL: https://github.com/apache/iceberg/pull/3915#discussion_r786478437
##########
File path: dev/source-release.sh
##########
@@ -36,7 +36,8 @@ usage () {
}
# Default repository remote name
-remote="apache"
+# Use origin so this can run on ASF infra or anywhere that directly clones the repository.
+remote="origin"
Review comment:
As we check the existence of the remote, we can move back to `apache` and update any existing automation (if any).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick removed a comment on pull request #3915: Build: Fix source-release script to run anywhere automated and add validation that remote git repo exists
Posted by GitBox <gi...@apache.org>.
kbendick removed a comment on pull request #3915:
URL: https://github.com/apache/iceberg/pull/3915#issuecomment-1015141028
Nevermind, I just noticed that `r` is earlier on in the arguments list. I thought it had been removed.
I'm going to change this to update back to `origin`. We can close it if we don't believe this runs on any GH runners or anywhere but a PMC / release managers local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #3915: Build: Fix source-release script to run anywhere automated and add validation that remote git repo exists
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #3915:
URL: https://github.com/apache/iceberg/pull/3915#discussion_r786478437
##########
File path: dev/source-release.sh
##########
@@ -36,7 +36,8 @@ usage () {
}
# Default repository remote name
-remote="apache"
+# Use origin so this can run on ASF infra or anywhere that directly clones the repository.
+remote="origin"
Review comment:
As we check the existence of the remote, we can move back to `apache` and update any existing automation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #3915: Build: Fix source-release script to run anywhere that directly clones the repo (such as automation, GH Actions)
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #3915:
URL: https://github.com/apache/iceberg/pull/3915#discussion_r786478437
##########
File path: dev/source-release.sh
##########
@@ -36,7 +36,8 @@ usage () {
}
# Default repository remote name
-remote="apache"
+# Use origin so this can run on ASF infra or anywhere that directly clones the repository.
+remote="origin"
Review comment:
Alternatively, we can add upstream as apache or ensure that it's installed that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3915: Build: Fix source-release script to run anywhere automated and add validation that remote git repo exists
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3915:
URL: https://github.com/apache/iceberg/pull/3915#issuecomment-1015581216
Looks like a good change to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org