You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Eli Collins (Created) (JIRA)" <ji...@apache.org> on 2012/02/15 00:38:00 UTC

[jira] [Created] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Small bug in hadoop error message for unknown commands
------------------------------------------------------

                 Key: HADOOP-8074
                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
             Project: Hadoop Common
          Issue Type: Bug
          Components: scripts
    Affects Versions: 0.24.0
            Reporter: Eli Collins
            Assignee: Colin Patrick McCabe
            Priority: Trivial
             Fix For: 0.23.2


The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".

{noformat}
hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
at: Unknown command
{noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208886#comment-13208886 ] 

Hudson commented on HADOOP-8074:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #1733 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1733/])
    HADOOP-8074. Small bug in hadoop error message for unknown commands. Contributed by Colin Patrick McCabe (Revision 1244766)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244766
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java

                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208884#comment-13208884 ] 

Hudson commented on HADOOP-8074:
--------------------------------

Integrated in Hadoop-Common-0.23-Commit #557 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/557/])
    HADOOP-8074. svn merge -c 1244766 from trunk (Revision 1244768)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244768
Files : 
* /hadoop/common/branches/branch-0.23
* /hadoop/common/branches/branch-0.23/hadoop-common-project
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
* /hadoop/common/branches/branch-0.23/hadoop-project
* /hadoop/common/branches/branch-0.23/hadoop-project/src/site

                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Colin Patrick McCabe (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Patrick McCabe updated HADOOP-8074:
-----------------------------------------

    Attachment: HADOOP-8074.txt

patch attached

Try to help users who specified a command without the mandatory leading dash.
                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208941#comment-13208941 ] 

Hudson commented on HADOOP-8074:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #1745 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1745/])
    HADOOP-8074. Small bug in hadoop error message for unknown commands. Contributed by Colin Patrick McCabe (Revision 1244766)

     Result = ABORTED
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244766
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java

                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209312#comment-13209312 ] 

Hudson commented on HADOOP-8074:
--------------------------------

Integrated in Hadoop-Hdfs-0.23-Build #170 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/170/])
    HADOOP-8074. svn merge -c 1244766 from trunk (Revision 1244768)

     Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244768
Files : 
* /hadoop/common/branches/branch-0.23
* /hadoop/common/branches/branch-0.23/hadoop-common-project
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
* /hadoop/common/branches/branch-0.23/hadoop-project
* /hadoop/common/branches/branch-0.23/hadoop-project/src/site

                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Tom White (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208922#comment-13208922 ] 

Tom White commented on HADOOP-8074:
-----------------------------------

I think this should be reverted so Daryn's feedback can be addressed. 
                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Aaron T. Myers (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HADOOP-8074:
-----------------------------------

    Fix Version/s:     (was: 0.23.2)
    
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HADOOP-8074:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I've committed this and merged to branch. Thanks Colin!
                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209339#comment-13209339 ] 

Hudson commented on HADOOP-8074:
--------------------------------

Integrated in Hadoop-Mapreduce-0.23-Build #198 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/198/])
    HADOOP-8074. svn merge -c 1244766 from trunk (Revision 1244768)

     Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244768
Files : 
* /hadoop/common/branches/branch-0.23
* /hadoop/common/branches/branch-0.23/hadoop-common-project
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
* /hadoop/common/branches/branch-0.23/hadoop-project
* /hadoop/common/branches/branch-0.23/hadoop-project/src/site

                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208924#comment-13208924 ] 

Daryn Sharp commented on HADOOP-8074:
-------------------------------------

Or for user-friendliness, something like this.  I was hoping someday to make the leading dash optional if I got around to adding interactive readline support.

{code}
--- hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java	(revision 1242960)
+++ hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java	(working copy)
@@ -23,6 +23,7 @@
 import java.util.Arrays;
 import java.util.LinkedList;
 
+import org.apache.commons.lang.StringUtils;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.apache.hadoop.classification.InterfaceAudience;
@@ -251,11 +252,15 @@
         if (instance == null) {
           throw new UnknownCommandException();
         }
+        cmd = instance.getName();
         exitCode = instance.run(Arrays.copyOfRange(argv, 1, argv.length));
       } catch (IllegalArgumentException e) {
         displayError(cmd, e.getLocalizedMessage());
         if (instance != null) {
           printInstanceUsage(System.err, instance);
+        } else {
+          System.err.println("Available commands: " +
+              StringUtils.join(commandFactory.getNames(), " "));
         }
       } catch (Exception e) {
         // instance.run catches IOE, so something is REALLY wrong if here
@@ -269,7 +274,7 @@
   
   private void displayError(String cmd, String message) {
     for (String line : message.split("\n")) {
-      System.err.println(cmd.substring(1) + ": " + line);
+      System.err.println(cmd + ": " + line);
     }
   }
{code}
                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208891#comment-13208891 ] 

Daryn Sharp commented on HADOOP-8074:
-------------------------------------

I guess my request to review got overlooked.  FsShell is not designed to enforce a leading dash, it's actually completely generic and it just happens that commands today start with a dash.  The more correct patch would have been:
{code}

--- hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java	(revision 1242960)
+++ hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java	(working copy)
@@ -251,6 +251,7 @@
         if (instance == null) {
           throw new UnknownCommandException();
         }
+        cmd = instance.getName();
         exitCode = instance.run(Arrays.copyOfRange(argv, 1, argv.length));
       } catch (IllegalArgumentException e) {
         displayError(cmd, e.getLocalizedMessage());
@@ -269,7 +270,7 @@
   
   private void displayError(String cmd, String message) {
     for (String line : message.split("\n")) {
-      System.err.println(cmd.substring(1) + ": " + line);
+      System.err.println(cmd + ": " + line);
     }
   }
{code}
                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HADOOP-8074:
--------------------------------

    Target Version/s:   (was: 0.23.2)
       Fix Version/s: 0.23.2
    
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208968#comment-13208968 ] 

Eli Collins commented on HADOOP-8074:
-------------------------------------

Hey Daryn,

Sorry, missed your comment in the stream of comments!  Mind filing a jira for your suggested improvement?  I'd be happy to review / commit.

Also, how about filing a jira for your idea of making the leading dash optional?  It's currently not optional in FsShell (all hadoop commands must have form <cmd> <-cmd>) which is why I think the current change is reasonable.

Thanks,
Eli
                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208810#comment-13208810 ] 

Eli Collins commented on HADOOP-8074:
-------------------------------------

Forgot to mention, Colin tried to add a test but ran into HADOOP-7360 / HDFS-2038, I'll ping those jiras. We'll test the output of TestHDFSCLI w/ and w/o this change for sanity. Given that it only updates the error handling path it shouldn't have an impact.
                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209318#comment-13209318 ] 

Hudson commented on HADOOP-8074:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #957 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/957/])
    HADOOP-8074. Small bug in hadoop error message for unknown commands. Contributed by Colin Patrick McCabe (Revision 1244766)

     Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244766
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java

                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208977#comment-13208977 ] 

Hudson commented on HADOOP-8074:
--------------------------------

Integrated in Hadoop-Mapreduce-0.23-Commit #560 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/560/])
    HADOOP-8074. svn merge -c 1244766 from trunk (Revision 1244768)

     Result = ABORTED
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244768
Files : 
* /hadoop/common/branches/branch-0.23
* /hadoop/common/branches/branch-0.23/hadoop-common-project
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
* /hadoop/common/branches/branch-0.23/hadoop-project
* /hadoop/common/branches/branch-0.23/hadoop-project/src/site

                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209357#comment-13209357 ] 

Hudson commented on HADOOP-8074:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #992 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/992/])
    HADOOP-8074. Small bug in hadoop error message for unknown commands. Contributed by Colin Patrick McCabe (Revision 1244766)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244766
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java

                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208866#comment-13208866 ] 

Eli Collins commented on HADOOP-8074:
-------------------------------------

bq. -1 tests included. 

Waiting on HDFS-2038.
                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208888#comment-13208888 ] 

Hudson commented on HADOOP-8074:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1807 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1807/])
    HADOOP-8074. Small bug in hadoop error message for unknown commands. Contributed by Colin Patrick McCabe (Revision 1244766)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244766
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java

                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Colin Patrick McCabe (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209043#comment-13209043 ] 

Colin Patrick McCabe commented on HADOOP-8074:
----------------------------------------------

Hi Daryn,

I like your idea of accepting the commands without a leading dash.  It makes sense to me.

Another improvement we could consider is enhancing FsShell to do a more general "did you mean" type search.  You could point out the one or two commands with the shortest Levenstein distance from what the user entered.

For now, this change catches the fairly common case where a first-time user types the command without a dash, and then is mystified when it doesn't work.  I know that this can happen because I was that first-time user at one point!

Colin
                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208825#comment-13208825 ] 

Hadoop QA commented on HADOOP-8074:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12514712/HADOOP-8074.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/603//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/603//console

This message is automatically generated.
                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209481#comment-13209481 ] 

Daryn Sharp commented on HADOOP-8074:
-------------------------------------

Levenstein is a very cool idea for suggesting alternatives!  Apache Common's StringUtils even has a method for it.  It's a handful of lines to implement, so I can post a patch with it later today if you can please help me out with updating the hdfs tests since I've got more demanding priorities...
                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HADOOP-8074:
--------------------------------

    Hadoop Flags: Reviewed
          Status: Patch Available  (was: Open)

+1 looks good pending jenkins
                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208858#comment-13208858 ] 

Daryn Sharp commented on HADOOP-8074:
-------------------------------------

Let me take a quick look at this...
                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208882#comment-13208882 ] 

Hudson commented on HADOOP-8074:
--------------------------------

Integrated in Hadoop-Hdfs-0.23-Commit #544 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/544/])
    HADOOP-8074. svn merge -c 1244766 from trunk (Revision 1244768)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244768
Files : 
* /hadoop/common/branches/branch-0.23
* /hadoop/common/branches/branch-0.23/hadoop-common-project
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
* /hadoop/common/branches/branch-0.23/hadoop-project
* /hadoop/common/branches/branch-0.23/hadoop-project/src/site

                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209556#comment-13209556 ] 

Eli Collins commented on HADOOP-8074:
-------------------------------------

Agree. Let's knock out your (Daryn's) suggested improvements and at least file a jira for accepting commands without a leading dash as well.
                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 0.23.2
>
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208816#comment-13208816 ] 

Hadoop QA commented on HADOOP-8074:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12514712/HADOOP-8074.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/602//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/602//console

This message is automatically generated.
                
> Small bug in hadoop error message for unknown commands
> ------------------------------------------------------
>
>                 Key: HADOOP-8074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8074
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.24.0
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>         Attachments: HADOOP-8074.txt
>
>
> The hadoop fs command should be more user friendly if the user forgets the dash before the command. Also, this should say "cat" rather than "at".
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hadoop fs cat
> at: Unknown command
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira