You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/19 08:30:13 UTC

[GitHub] [tvm] CaptainDuke opened a new pull request #7880: DEBUG: Convert tuple to int

CaptainDuke opened a new pull request #7880:
URL: https://github.com/apache/tvm/pull/7880


   If param stride is tuple, like (1, 1), errors would occur like following:
   
   `
   File "xxx/python/tvm/topi/testing/conv2d_hwcn_python.py", line 76, in conv2d_hwcn_python
   bt[n, f] += out[::stride, ::stride]
   TypeError: slice indices must be integers or None or have an __index__ method
   `
   
   Because tuple has not been handled correctly in line: 52


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] CaptainDuke commented on pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
CaptainDuke commented on pull request #7880:
URL: https://github.com/apache/tvm/pull/7880#issuecomment-826020768


   @tqchen @jcf94 
   I pushed a new commit again but CI for ARM failed once more. How could I pass this test in a easier way?
   
   ```
   + docker/bash.sh tlcpack/ci-arm:v0.03 ./tests/scripts/task_config_build_arm.sh
   
   WORKSPACE: /home/jenkins/workspace/exec_0/tvm/build-arm
   
   DOCKER CONTAINER NAME: tlcpack/ci-arm:v0.03
   
   
   
   Running './tests/scripts/task_config_build_arm.sh' inside tlcpack/ci-arm:v0.03...
   
   docker/bash.sh: line 152: docker: command not found
   
   script returned exit code 127
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] CaptainDuke removed a comment on pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
CaptainDuke removed a comment on pull request #7880:
URL: https://github.com/apache/tvm/pull/7880#issuecomment-826020768


   @tqchen @jcf94 
   I pushed a new commit again but CI for ARM failed once more. How could I pass this test in a easier way?
   
   ```
   + docker/bash.sh tlcpack/ci-arm:v0.03 ./tests/scripts/task_config_build_arm.sh
   
   WORKSPACE: /home/jenkins/workspace/exec_0/tvm/build-arm
   
   DOCKER CONTAINER NAME: tlcpack/ci-arm:v0.03
   
   
   
   Running './tests/scripts/task_config_build_arm.sh' inside tlcpack/ci-arm:v0.03...
   
   docker/bash.sh: line 152: docker: command not found
   
   script returned exit code 127
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] CaptainDuke commented on pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
CaptainDuke commented on pull request #7880:
URL: https://github.com/apache/tvm/pull/7880#issuecomment-822308329


   @tqchen Please review this pr, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jcf94 commented on pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
jcf94 commented on pull request #7880:
URL: https://github.com/apache/tvm/pull/7880#issuecomment-825351635


   > > > > Thanks @CaptainDuke can you add a regression test to this bug?
   > > > 
   > > > 
   > > > Test cases added.
   > > > Besides, I found duplicated test cases and changed batch_size from 256 to 128.
   > > 
   > > 
   > > Thanks! We can merge this once all CI jobs have been cleaned.
   > 
   > @jcf94 Could you please merge this PR? The CI job seems failed due to test_vm_rpc.
   
   E ... This is the limit of Github, I'm not able to merge it if the CI has not passed.
   I see that the CI error is not related to this PR, you can try to push a new commit to re-trigger the CI. It may pass next time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7880:
URL: https://github.com/apache/tvm/pull/7880#issuecomment-822426400


   Thanks @CaptainDuke can you add a regression test to this bug?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] CaptainDuke commented on pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
CaptainDuke commented on pull request #7880:
URL: https://github.com/apache/tvm/pull/7880#issuecomment-822977586


   > Thanks @CaptainDuke can you add a regression test to this bug?
   
   Test cases added.
   Besides, I found duplicated test cases and changed batch_size from 256 to 128.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jcf94 edited a comment on pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
jcf94 edited a comment on pull request #7880:
URL: https://github.com/apache/tvm/pull/7880#issuecomment-823194280


   > > Thanks @CaptainDuke can you add a regression test to this bug?
   > 
   > Test cases added.
   > Besides, I found duplicated test cases and changed batch_size from 256 to 128.
   
   Thanks! We can merge this once all CI jobs have been cleaned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] CaptainDuke commented on pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
CaptainDuke commented on pull request #7880:
URL: https://github.com/apache/tvm/pull/7880#issuecomment-826193001


   @tqchen @jcf94 Ready to merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jcf94 merged pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
jcf94 merged pull request #7880:
URL: https://github.com/apache/tvm/pull/7880


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] CaptainDuke edited a comment on pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
CaptainDuke edited a comment on pull request #7880:
URL: https://github.com/apache/tvm/pull/7880#issuecomment-822977586


   > Thanks @CaptainDuke can you add a regression test to this bug?
   
   @tqchen Test cases added.
   Besides, I found duplicated test cases and changed batch_size from 256 to 128.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] CaptainDuke commented on pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
CaptainDuke commented on pull request #7880:
URL: https://github.com/apache/tvm/pull/7880#issuecomment-825350869


   > > > Thanks @CaptainDuke can you add a regression test to this bug?
   > > 
   > > 
   > > Test cases added.
   > > Besides, I found duplicated test cases and changed batch_size from 256 to 128.
   > 
   > Thanks! We can merge this once all CI jobs have been cleaned.
   
   Could you please merge this PR? The CI job seems failed due to test_vm_rpc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] CaptainDuke removed a comment on pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
CaptainDuke removed a comment on pull request #7880:
URL: https://github.com/apache/tvm/pull/7880#issuecomment-826020768


   @tqchen @jcf94 
   I pushed a new commit again but CI for ARM failed once more. How could I pass this test in a easier way?
   
   ```
   + docker/bash.sh tlcpack/ci-arm:v0.03 ./tests/scripts/task_config_build_arm.sh
   
   WORKSPACE: /home/jenkins/workspace/exec_0/tvm/build-arm
   
   DOCKER CONTAINER NAME: tlcpack/ci-arm:v0.03
   
   
   
   Running './tests/scripts/task_config_build_arm.sh' inside tlcpack/ci-arm:v0.03...
   
   docker/bash.sh: line 152: docker: command not found
   
   script returned exit code 127
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jcf94 edited a comment on pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
jcf94 edited a comment on pull request #7880:
URL: https://github.com/apache/tvm/pull/7880#issuecomment-825351635


   > > > > Thanks @CaptainDuke can you add a regression test to this bug?
   > > > 
   > > > 
   > > > Test cases added.
   > > > Besides, I found duplicated test cases and changed batch_size from 256 to 128.
   > > 
   > > 
   > > Thanks! We can merge this once all CI jobs have been cleaned.
   > 
   > @jcf94 Could you please merge this PR? The CI job seems failed due to test_vm_rpc.
   
   E ... Due to the limitation of Github, I'm not able to merge it if the CI has not passed.
   I see that the CI error is not related to this PR, you can try to push a new commit to re-trigger the CI. It may pass next time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] CaptainDuke commented on pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
CaptainDuke commented on pull request #7880:
URL: https://github.com/apache/tvm/pull/7880#issuecomment-826193001


   @tqchen @jcf94 Ready to merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] CaptainDuke edited a comment on pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
CaptainDuke edited a comment on pull request #7880:
URL: https://github.com/apache/tvm/pull/7880#issuecomment-825350869


   > > > Thanks @CaptainDuke can you add a regression test to this bug?
   > > 
   > > 
   > > Test cases added.
   > > Besides, I found duplicated test cases and changed batch_size from 256 to 128.
   > 
   > Thanks! We can merge this once all CI jobs have been cleaned.
   
   @jcf94 Could you please merge this PR? The CI job seems failed due to test_vm_rpc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jcf94 merged pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
jcf94 merged pull request #7880:
URL: https://github.com/apache/tvm/pull/7880


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jcf94 commented on pull request #7880: [BugFix]: Convert tuple to int

Posted by GitBox <gi...@apache.org>.
jcf94 commented on pull request #7880:
URL: https://github.com/apache/tvm/pull/7880#issuecomment-823194280


   > > Thanks @CaptainDuke can you add a regression test to this bug?
   > 
   > Test cases added.
   > Besides, I found duplicated test cases and changed batch_size from 256 to 128.
   
   Thanks! We can merge this after all CI jobs have been cleaned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org