You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/10/18 15:26:26 UTC

[GitHub] [hive] dengzhhu653 commented on a diff in pull request #3674: HIVE-26633: Make Thrift MaxMessageSize configurable

dengzhhu653 commented on code in PR #3674:
URL: https://github.com/apache/hive/pull/3674#discussion_r998393428


##########
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:
##########
@@ -881,11 +881,27 @@ private TTransport createUnderlyingTransport() throws TTransportException {
       }
     } else {
       // get non-SSL socket transport
-      transport = HiveAuthUtils.getSocketTransport(host, port, loginTimeout);
+      transport = HiveAuthUtils.getSocketTransport(host, port, loginTimeout, maxMessageSize);
     }
     return transport;

Review Comment:
   nit: can we set the `maxMessageSize` by `transport.getConfiguration().setMaxMessageSize()` for both non-SSL and SSL transport?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org