You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jbbqqf (via GitHub)" <gi...@apache.org> on 2026/05/09 16:42:50 UTC
[PR] fix(explore): remove leftover debug console.log in ZoomConfigControl [superset]
jbbqqf opened a new pull request, #39991:
URL: https://github.com/apache/superset/pull/39991
### SUMMARY
Drops a leftover debug `console.log('now in onbasewidthcahnge')` (note the typo) from `onBaseWidthChange` in `ZoomConfigControl.tsx`. The statement fires on every drag of the Base Width slider in the Explore view, polluting the browser console during normal usage. Pure cleanup — no behavior change.
Fixes apache/superset#39622 — *Leftover Debug Statement Polluting Console in ZoomConfigControl*
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable — the only observable change is the absence of one line in the DevTools console while dragging the Base Width slider.
### TESTING INSTRUCTIONS
#### Reproduce BEFORE/AFTER yourself (copy-paste)
A reviewer can confirm by inspection — only the exact message changes between BEFORE and AFTER.
```bash
# --- one-time setup ---
git clone https://github.com/apache/superset.git /tmp/repro && cd /tmp/repro
# --- BEFORE (origin/master) ---
git checkout origin/master
grep -n "onbasewidthcahnge" superset-frontend/src/explore/components/controls/ZoomConfigControl/ZoomConfigControl.tsx
# Expected: line 69 prints `console.log('now in onbasewidthcahnge');`
# --- AFTER (this PR) ---
git fetch https://github.com/jbbqqf/superset.git feat/39622-remove-zoomconfig-debug-log
git checkout FETCH_HEAD
grep -n "onbasewidthcahnge" superset-frontend/src/explore/components/controls/ZoomConfigControl/ZoomConfigControl.tsx
# Expected: no output; the debug statement is gone.
# Optional UI verification (requires the superset-frontend dev server):
# cd superset-frontend && npm ci && npm run dev-server
# Open Explore on a chart that uses ZoomConfigControl, drag the Base Width
# slider, and inspect the browser DevTools console.
# BEFORE: 'now in onbasewidthcahnge' fires on every drag event.
# AFTER : the console stays clean during dragging.
```
#### What I ran locally
- `grep -n "console\." superset-frontend/src/explore/components/controls/ZoomConfigControl/` — confirmed the file no longer has any `console.*` calls after the change.
- The repository's frontend ESLint config sets `no-console: 'warn'` (not `error`), which is why this leftover slipped through CI; this PR does not change that policy.
- No regression test added: this is a pure-cleanup one-line removal with no behavioral divergence to assert. The grep above is the equivalence check.
### ADDITIONAL INFORMATION
| # | Scenario | Input | Expected | Verified by |
|---|----------|-------|----------|-------------|
| 1 | Default behavior | drag Base Width slider | console stays clean | grep on file confirms line removed |
- [x] Has associated issue: #39622
- [ ] Required feature flags:
- [x] Changes UI (only in the sense of console output during dev usage; visible chart behavior is unchanged)
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
#### Risk / blast radius
Zero. The removed line was a `console.log` with no surrounding control flow. `setBaseWidth(width)` and the rest of `onBaseWidthChange` are untouched.
```release-note
Removed a leftover debug console.log from the Base Width slider in ZoomConfigControl.
```
---
*PR drafted with assistance from Claude Code. The change was reviewed manually against apache/superset's source. The reproducer block above was used during development; it is the same one a reviewer can paste verbatim.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): remove leftover debug console.log in ZoomConfigControl [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #39991:
URL: https://github.com/apache/superset/pull/39991#issuecomment-4423294788
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/39991?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 63.83%. Comparing base ([`f67dd4a`](https://app.codecov.io/gh/apache/superset/commit/f67dd4a8f3af0d5395f4cb95ab3c1d593c8d867f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de19fb`](https://app.codecov.io/gh/apache/superset/commit/4de19fb6ebbb2168e5d81781bdf124816182794b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 27 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #39991 +/- ##
=======================================
Coverage 63.83% 63.83%
=======================================
Files 2589 2589
Lines 137821 137820 -1
Branches 31928 31928
=======================================
+ Hits 87978 87979 +1
+ Misses 48327 48325 -2
Partials 1516 1516
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/39991/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/39991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.53% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/39991?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): remove leftover debug console.log in ZoomConfigControl [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39991:
URL: https://github.com/apache/superset/pull/39991#issuecomment-4413023774
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): remove leftover debug console.log in ZoomConfigControl [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #39991:
URL: https://github.com/apache/superset/pull/39991#issuecomment-4423068500
Thanks for the fix! Will merge if/when CI turns green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): remove leftover debug console.log in ZoomConfigControl [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe merged PR #39991:
URL: https://github.com/apache/superset/pull/39991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org