You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/04/07 10:28:52 UTC
[GitHub] [helix] hmhagberg opened a new pull request, #2021: Improve ZkClientMonitor and ZkClientPathMonitor performance
hmhagberg opened a new pull request, #2021:
URL: https://github.com/apache/helix/pull/2021
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fixes #2020
### Description
- Replace `String#matches` with more efficient `String#contains` in `ZkClientPathMonitor`
- Refactor `record*` methods in `ZkClientMonitor` to avoid repetition and simplify matching logic
### Tests
- [ ] The following tests are written for this issue:
Covered by existing tests, in particular
- org.apache.helix.zookeeper.impl.client.TestRawZkClient
- org.apache.helix.monitoring.mbeans.TestZkClientMonitor
- The following is the result of the "mvn test" command on the appropriate module:
```
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestNoThrottleDisabledPartitions.testDisablingTopStateReplicaByDisablingInstance:98 expected:<false> but was:<true>
[ERROR] TestNoThrottleDisabledPartitions.testNoThrottleOnDisabledInstance:231->setupEnvironment:317->setupCluster:436 ยป ZkClient
[ERROR] TestP2PNoDuplicatedMessage.testP2PStateTransitionEnabled:180 expected:<true> but was:<false>
[ERROR] TestRecurringJobQueue.testDeletingRecurrentQueueWithHistory:298 expected:<true> but was:<false>
[ERROR] TestResourceThreadpoolSize.testBatchMessageThreadPoolSize:206 expected:<true> but was:<false>
[INFO]
[ERROR] Tests run: 1300, Failures: 5, Errors: 0, Skipped: 0
```
All of the failures appear to be unrelated
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly merged pull request #2021: Improve ZkClientMonitor and ZkClientPathMonitor performance
Posted by GitBox <gi...@apache.org>.
narendly merged PR #2021:
URL: https://github.com/apache/helix/pull/2021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org