You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by th...@apache.org on 2008/06/26 05:32:04 UTC
svn commit: r671715 -
/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Author: thrantal
Date: Wed Jun 25 20:32:04 2008
New Revision: 671715
URL: http://svn.apache.org/viewvc?rev=671715&view=rev
Log:
WICKET-1713: Fixed the case where elements with stored tabIndexes are updated via ajax between opening and closing the ModalWindow. The DOM elements coming from the server don't have the custom property that was set to the instances of the client, so the (usually correct) tabIndex coming from the server must not be overwritten with null.
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js?rev=671715&r1=671714&r2=671715&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js Wed Jun 25 20:32:04 2008
@@ -1447,8 +1447,10 @@
var tagElements = this.document.getElementsByTagName(this.tabbableTags[j]);
for (var k = 0 ; k < tagElements.length; k++) {
var element = tagElements[k];
- element.tabIndex = element.hiddenTabIndex;
- element.hiddenTabIndex = null;
+ if (typeof(element.hiddenTabIndex) != 'undefined') {
+ element.tabIndex = element.hiddenTabIndex;
+ element.hiddenTabIndex = null;
+ }
element.tabEnabled = true;
}
}