You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/12/11 09:55:21 UTC
[native-toolchain-CR] IMPALA-9238: Make package libtool building work on aarch64
huangtianhua223@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14889
Change subject: IMPALA-9238: Make package libtool building work on aarch64
......................................................................
IMPALA-9238: Make package libtool building work on aarch64
Set correct CONFIGURE_FLAG_BUILD_SYS to make
sure libtool building success on aarch64.
Change-Id: I00369fc3e69ebb759870147b027bca097716879d
---
M init.sh
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/89/14889/1
--
To view, visit http://gerrit.cloudera.org:8080/14889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00369fc3e69ebb759870147b027bca097716879d
Gerrit-Change-Number: 14889
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
[native-toolchain-CR] IMPALA-9238: Make package libtool building work on aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14889 )
Change subject: IMPALA-9238: Make package libtool building work on aarch64
......................................................................
IMPALA-9238: Make package libtool building work on aarch64
Set correct CONFIGURE_FLAG_BUILD_SYS to make
sure libtool building success on aarch64.
Change-Id: I00369fc3e69ebb759870147b027bca097716879d
Reviewed-on: http://gerrit.cloudera.org:8080/14889
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M init.sh
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I00369fc3e69ebb759870147b027bca097716879d
Gerrit-Change-Number: 14889
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] IMPALA-9238: Make package libtool building work on aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14889 )
Change subject: IMPALA-9238: Make package libtool building work on aarch64
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00369fc3e69ebb759870147b027bca097716879d
Gerrit-Change-Number: 14889
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Dec 2019 18:47:51 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9238: Make package libtool building work on aarch64
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14889 )
Change subject: IMPALA-9238: Make package libtool building work on aarch64
......................................................................
Patch Set 2:
Tim Armstrong,
Sorry, I made a mistake to rebase it, please review it again, thanks.
--
To view, visit http://gerrit.cloudera.org:8080/14889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00369fc3e69ebb759870147b027bca097716879d
Gerrit-Change-Number: 14889
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 03:22:16 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9238: Make package libtool building work on aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14889 )
Change subject: IMPALA-9238: Make package libtool building work on aarch64
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00369fc3e69ebb759870147b027bca097716879d
Gerrit-Change-Number: 14889
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 16:52:19 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9238: Make package libtool building work on aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14889 )
Change subject: IMPALA-9238: Make package libtool building work on aarch64
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00369fc3e69ebb759870147b027bca097716879d
Gerrit-Change-Number: 14889
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 16:52:23 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9238: Make package libtool building work on aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14889 )
Change subject: IMPALA-9238: Make package libtool building work on aarch64
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00369fc3e69ebb759870147b027bca097716879d
Gerrit-Change-Number: 14889
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Dec 2019 18:48:02 +0000
Gerrit-HasComments: No