You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by as...@apache.org on 2017/12/04 19:00:25 UTC

[5/5] qpid-proton git commit: NO-JIRA: Avoid mismatched comparison warnings on Visual Studio

NO-JIRA: Avoid mismatched comparison warnings on Visual Studio


Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/88a927ec
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/88a927ec
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/88a927ec

Branch: refs/heads/master
Commit: 88a927ecb06e01e5dc1086cd6470c359a54eb0b0
Parents: f88c826
Author: Andrew Stitcher <as...@apache.org>
Authored: Fri Dec 1 15:38:31 2017 -0500
Committer: Andrew Stitcher <as...@apache.org>
Committed: Mon Dec 4 13:49:36 2017 -0500

----------------------------------------------------------------------
 proton-c/src/proactor/win_iocp.c                 | 6 +++---
 proton-c/src/reactor/io/windows/iocp.h           | 2 +-
 proton-c/src/reactor/io/windows/write_pipeline.c | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/88a927ec/proton-c/src/proactor/win_iocp.c
----------------------------------------------------------------------
diff --git a/proton-c/src/proactor/win_iocp.c b/proton-c/src/proactor/win_iocp.c
index 51b4874..0d276e8 100644
--- a/proton-c/src/proactor/win_iocp.c
+++ b/proton-c/src/proactor/win_iocp.c
@@ -99,7 +99,7 @@ typedef struct iocp_t iocp_t;
 struct iocp_t {
   HANDLE completion_port;
   pn_list_t *zombie_list;
-  int shared_pool_size;
+  unsigned shared_pool_size;
   char *shared_pool_memory;
   write_result_t **shared_results;
   write_result_t **available_results;
@@ -276,7 +276,7 @@ void pni_shared_pool_create(iocp_t *iocp)
     iocp->available_results = (write_result_t **) malloc(iocp->shared_pool_size * sizeof(write_result_t *));
     iocp->shared_available_count = iocp->shared_pool_size;
     char *mem = iocp->shared_pool_memory;
-    for (int i = 0; i < iocp->shared_pool_size; i++) {
+    for (unsigned i = 0; i < iocp->shared_pool_size; i++) {
       iocp->shared_results[i] = iocp->available_results[i] = pni_write_result(NULL, mem, IOCP_WBUFSIZE);
       mem += IOCP_WBUFSIZE;
     }
@@ -285,7 +285,7 @@ void pni_shared_pool_create(iocp_t *iocp)
 
 void pni_shared_pool_free(iocp_t *iocp)
 {
-  for (int i = 0; i < iocp->shared_pool_size; i++) {
+  for (unsigned i = 0; i < iocp->shared_pool_size; i++) {
     write_result_t *result = iocp->shared_results[i];
     if (result->in_use)
       pipeline_log("Proton buffer pool leak\n");

http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/88a927ec/proton-c/src/reactor/io/windows/iocp.h
----------------------------------------------------------------------
diff --git a/proton-c/src/reactor/io/windows/iocp.h b/proton-c/src/reactor/io/windows/iocp.h
index 07f47be..6cf0bc0 100644
--- a/proton-c/src/reactor/io/windows/iocp.h
+++ b/proton-c/src/reactor/io/windows/iocp.h
@@ -39,7 +39,7 @@ struct iocp_t {
   HANDLE completion_port;
   pn_hash_t *iocpdesc_map;
   pn_list_t *zombie_list;
-  int shared_pool_size;
+  unsigned shared_pool_size;
   char *shared_pool_memory;
   write_result_t **shared_results;
   write_result_t **available_results;

http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/88a927ec/proton-c/src/reactor/io/windows/write_pipeline.c
----------------------------------------------------------------------
diff --git a/proton-c/src/reactor/io/windows/write_pipeline.c b/proton-c/src/reactor/io/windows/write_pipeline.c
index 905c7f6..238303c 100644
--- a/proton-c/src/reactor/io/windows/write_pipeline.c
+++ b/proton-c/src/reactor/io/windows/write_pipeline.c
@@ -96,7 +96,7 @@ void pni_shared_pool_create(iocp_t *iocp)
     iocp->available_results = (write_result_t **) malloc(iocp->shared_pool_size * sizeof(write_result_t *));
     iocp->shared_available_count = iocp->shared_pool_size;
     char *mem = iocp->shared_pool_memory;
-    for (int i = 0; i < iocp->shared_pool_size; i++) {
+    for (unsigned i = 0; i < iocp->shared_pool_size; i++) {
       iocp->shared_results[i] = iocp->available_results[i] = pni_write_result(NULL, mem, IOCP_WBUFSIZE);
       mem += IOCP_WBUFSIZE;
     }
@@ -105,7 +105,7 @@ void pni_shared_pool_create(iocp_t *iocp)
 
 void pni_shared_pool_free(iocp_t *iocp)
 {
-  for (int i = 0; i < iocp->shared_pool_size; i++) {
+  for (unsigned i = 0; i < iocp->shared_pool_size; i++) {
     write_result_t *result = iocp->shared_results[i];
     if (result->in_use)
       pipeline_log("Proton buffer pool leak\n");


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org