[GitHub] [hudi] dongkelun commented on a diff in pull request #6448: [HUDI-4647] Change the default value of HIVE_SYNC_MODE in MergeInto to HMS

[GitBox <gi...@apache.org>]

dongkelun commented on code in PR #6448:
URL: https://github.com/apache/hudi/pull/6448#discussion_r963208245


##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala:
##########
@@ -495,7 +496,7 @@ case class MergeIntoHoodieTableCommand(mergeInto: MergeIntoTable) extends Hoodie
         KEYGENERATOR_CLASS_NAME.key -> classOf[SqlKeyGenerator].getCanonicalName,
         SqlKeyGenerator.ORIGIN_KEYGEN_CLASS_NAME -> tableConfig.getKeyGeneratorClassName,
         HoodieSyncConfig.META_SYNC_ENABLED.key -> enableHive.toString,
-        HiveSyncConfigHolder.HIVE_SYNC_MODE.key -> hiveSyncConfig.getString(HiveSyncConfigHolder.HIVE_SYNC_MODE),
+        HiveSyncConfigHolder.HIVE_SYNC_MODE.key -> hiveSyncConfig.getStringOrDefault(HiveSyncConfigHolder.HIVE_SYNC_MODE, HiveSyncMode.HMS.name()),

Review Comment:
   > Should we just add the default value below inside the `HiveSyncConfigHolder` class?
   > 
   > ```
   > public static final ConfigProperty<String> HIVE_SYNC_MODE = ConfigProperty
   >       .key("hoodie.datasource.hive_sync.mode")
   >       .noDefaultValue()
   >       .withDocumentation("Mode to choose for Hive ops. Valid values are hms, jdbc and hiveql.");
   > ```
   
   Here is to modify the global default value, which may affect a lot. I am not sure whether it is reasonable for each module. This PR only wants to change the default value corresponding to Spark SQL



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org