You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/12/23 00:32:49 UTC
[GitHub] [hbase] ndimiduk opened a new pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release
ndimiduk opened a new pull request #3974:
URL: https://github.com/apache/hbase/pull/3974
* Update our jdk11 build profile in the pom so that it uses the additional flag on javac, requires maven 3.6+.
* update create-release Dockerfile to use jdk11-headless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3974:
URL: https://github.com/apache/hbase/pull/3974#issuecomment-1000068872
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 10s | master passed |
| +1 :green_heart: | compile | 2m 46s | master passed |
| +1 :green_heart: | shadedjars | 8m 17s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 14s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 50s | the patch passed |
| +1 :green_heart: | compile | 2m 48s | the patch passed |
| +1 :green_heart: | javac | 2m 48s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 13s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 11s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 297m 50s | root in the patch failed. |
| | | 335m 20s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3974 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 9df5cc4f9864 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / f16b7b1bfa |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/1/testReport/ |
| Max. process+thread count | 2934 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3974:
URL: https://github.com/apache/hbase/pull/3974#issuecomment-999978655
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 12s | master passed |
| +1 :green_heart: | compile | 8m 59s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 46s | the patch passed |
| +1 :green_heart: | compile | 8m 57s | the patch passed |
| +1 :green_heart: | javac | 8m 57s | the patch passed |
| +1 :green_heart: | hadolint | 0m 1s | There were no new hadolint issues. |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 19m 21s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
| | | 54m 7s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3974 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs javac hadoopcheck xml compile |
| uname | Linux bd09fd0a4e9b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / f16b7b1bfa |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Max. process+thread count | 141 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/1/console |
| versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3974:
URL: https://github.com/apache/hbase/pull/3974#issuecomment-1005108975
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 2s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 50s | master passed |
| +1 :green_heart: | compile | 3m 16s | master passed |
| +1 :green_heart: | shadedjars | 8m 15s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 54s | master passed |
||| _ Patch Compile Tests _ |
| -1 :x: | mvninstall | 1m 9s | root in the patch failed. |
| -1 :x: | compile | 1m 0s | root in the patch failed. |
| -0 :warning: | javac | 1m 0s | root in the patch failed. |
| -1 :x: | shadedjars | 1m 27s | patch has 119 errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 18s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 1m 2s | root in the patch failed. |
| | | 26m 29s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3974 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux cd2718e20eed 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 70cb9b0ba9 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt |
| shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/2/testReport/ |
| Max. process+thread count | 135 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3974:
URL: https://github.com/apache/hbase/pull/3974#issuecomment-999969555
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 45s | master passed |
| +1 :green_heart: | compile | 3m 12s | master passed |
| +1 :green_heart: | shadedjars | 8m 21s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 51s | master passed |
||| _ Patch Compile Tests _ |
| -1 :x: | mvninstall | 1m 6s | root in the patch failed. |
| -1 :x: | compile | 1m 0s | root in the patch failed. |
| -0 :warning: | javac | 1m 0s | root in the patch failed. |
| -1 :x: | shadedjars | 1m 27s | patch has 119 errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 18s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 1m 3s | root in the patch failed. |
| | | 25m 47s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3974 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 65e74ea8096c 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / f16b7b1bfa |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt |
| shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/1/testReport/ |
| Max. process+thread count | 134 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #3974:
URL: https://github.com/apache/hbase/pull/3974#issuecomment-1005103719
It's never as simple as that...
```
$ env JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home mvn clean install assembly:single -DskipTests
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project hbase-common: Compilation failure: Compilation failure:
[ERROR] /Users/ndimiduk/repos/apache/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:[48,16] package sun.misc does not exist
[ERROR] /Users/ndimiduk/repos/apache/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java:[36,18] package sun.nio.ch does not exist
[ERROR] /Users/ndimiduk/repos/apache/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/nio/SingleByteBuff.java:[34,18] package sun.nio.ch does not exist
[ERROR] /Users/ndimiduk/repos/apache/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:[1360,20] cannot find symbol
[ERROR] symbol: class Unsafe
[ERROR] location: class org.apache.hadoop.hbase.util.Bytes.ConverterHolder.UnsafeConverter
[ERROR] /Users/ndimiduk/repos/apache/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:[1470,20] cannot find symbol
[ERROR] symbol: class Unsafe
[ERROR] location: class org.apache.hadoop.hbase.util.Bytes.LexicographicalComparerHolder.UnsafeComparer
[ERROR] /Users/ndimiduk/repos/apache/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java:[36,18] package sun.nio.ch does not exist
[ERROR] /Users/ndimiduk/repos/apache/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java:[31,16] package sun.misc does not exist
[ERROR] /Users/ndimiduk/repos/apache/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java:[32,18] package sun.nio.ch does not exist
[ERROR] /Users/ndimiduk/repos/apache/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java:[40,23] cannot find symbol
[ERROR] symbol: class Unsafe
[ERROR] location: class org.apache.hadoop.hbase.util.UnsafeAccess
[ERROR] /Users/ndimiduk/repos/apache/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java:[338,24] cannot find symbol
[ERROR] symbol: class DirectBuffer
[ERROR] location: class org.apache.hadoop.hbase.io.ByteBuffAllocator
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #3974:
URL: https://github.com/apache/hbase/pull/3974#issuecomment-999964413
Perhaps the change to `create-release` can be done in isolation to the change to the pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #3974:
URL: https://github.com/apache/hbase/pull/3974#issuecomment-1005192587
I'm pretty sure this will not work with today's version of JDK11 ; we appear to be blocked by [JDK-8214165](https://bugs.openjdk.java.net/browse/JDK-8214165).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #3974:
URL: https://github.com/apache/hbase/pull/3974#issuecomment-1005094596
> > Perhaps the change to `create-release` can be done in isolation to the change to the pom.
>
> Yes, let's have separated issues for these two changes. The create-release script needs manual verification.
Okay, I split out the changes. This issue is just the POM change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] madrob commented on a change in pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #3974:
URL: https://github.com/apache/hbase/pull/3974#discussion_r778326539
##########
File path: pom.xml
##########
@@ -1725,7 +1725,9 @@
yyyy-MM-dd'T'HH:mm
</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
+ <!-- these two control the Java language version and JVM runtime version supported -->
<compileSource>1.8</compileSource>
Review comment:
I believe that compile source and target allow setting `8` in addition to `1.8` while release requires `8` - can we standardize on a single value for all of these instead of have both 1.8 and 8 around?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #3974:
URL: https://github.com/apache/hbase/pull/3974#discussion_r778345876
##########
File path: pom.xml
##########
@@ -1725,7 +1725,9 @@
yyyy-MM-dd'T'HH:mm
</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
+ <!-- these two control the Java language version and JVM runtime version supported -->
<compileSource>1.8</compileSource>
Review comment:
Ah, indeed. https://docs.oracle.com/en/java/javase/11/tools/javac.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3974:
URL: https://github.com/apache/hbase/pull/3974#issuecomment-999992032
> Perhaps the change to `create-release` can be done in isolation to the change to the pom.
Yes, let's have separated issues for these two changes. The create-release script needs manual verification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3974:
URL: https://github.com/apache/hbase/pull/3974#issuecomment-1005126570
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 58s | master passed |
| +1 :green_heart: | compile | 9m 9s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 50s | the patch passed |
| +1 :green_heart: | compile | 9m 3s | the patch passed |
| +1 :green_heart: | javac | 9m 3s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 19m 40s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. |
| | | 54m 29s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3974 |
| Optional Tests | dupname asflicense javac hadoopcheck xml compile |
| uname | Linux 8eb739b342e2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 70cb9b0ba9 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Max. process+thread count | 141 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3974:
URL: https://github.com/apache/hbase/pull/3974#issuecomment-1005296457
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 58s | master passed |
| +1 :green_heart: | compile | 2m 48s | master passed |
| +1 :green_heart: | shadedjars | 8m 17s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 10s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 49s | the patch passed |
| +1 :green_heart: | compile | 2m 47s | the patch passed |
| +1 :green_heart: | javac | 2m 47s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 12s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 11s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 329m 6s | root in the patch failed. |
| | | 366m 29s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3974 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 21c8bb842c3d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 70cb9b0ba9 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/2/testReport/ |
| Max. process+thread count | 4886 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3974/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk closed pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release
Posted by GitBox <gi...@apache.org>.
ndimiduk closed pull request #3974:
URL: https://github.com/apache/hbase/pull/3974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org