You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ew...@apache.org on 2018/09/06 03:15:50 UTC
[kafka] branch 2.0 updated: KAFKA-7353: Connect logs 'this' for
anonymous inner classes
This is an automated email from the ASF dual-hosted git repository.
ewencp pushed a commit to branch 2.0
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/2.0 by this push:
new 7616ff4 KAFKA-7353: Connect logs 'this' for anonymous inner classes
7616ff4 is described below
commit 7616ff449a790811fc809b4c21f17f20561936e3
Author: Kevin Lafferty <ke...@gmail.com>
AuthorDate: Wed Sep 5 20:15:25 2018 -0700
KAFKA-7353: Connect logs 'this' for anonymous inner classes
Replace 'this' reference in anonymous inner class logs to out class's 'this'
Author: Kevin Lafferty <ke...@gmail.com>
Reviewers: Randall Hauch <rh...@gmail.com>, Arjun Satish <ar...@confluent.io>, Ewen Cheslack-Postava <ew...@confluent.io>
Closes #5583 from kevin-laff/connect_logging
(cherry picked from commit 847780e5a5f376fa2ce8705f483bfd33b319b83d)
Signed-off-by: Ewen Cheslack-Postava <me...@ewencp.org>
---
.../java/org/apache/kafka/connect/runtime/WorkerConnector.java | 2 +-
.../java/org/apache/kafka/connect/runtime/WorkerSinkTask.java | 2 +-
.../org/apache/kafka/connect/runtime/WorkerSourceTask.java | 10 +++++-----
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java
index 611e196..55d4860 100644
--- a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java
+++ b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java
@@ -89,7 +89,7 @@ public class WorkerConnector {
@Override
public void raiseError(Exception e) {
- log.error("{} Connector raised an error", this, e);
+ log.error("{} Connector raised an error", WorkerConnector.this, e);
onFailure(e);
ctx.raiseError(e);
}
diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java
index 47f8529..828f4a3 100644
--- a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java
+++ b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java
@@ -648,7 +648,7 @@ class WorkerSinkTask extends WorkerTask {
long pos = consumer.position(tp);
lastCommittedOffsets.put(tp, new OffsetAndMetadata(pos));
currentOffsets.put(tp, new OffsetAndMetadata(pos));
- log.debug("{} Assigned topic partition {} with offset {}", this, tp, pos);
+ log.debug("{} Assigned topic partition {} with offset {}", WorkerSinkTask.this, tp, pos);
}
sinkTaskMetricsGroup.assignedOffsets(currentOffsets);
diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
index 70d0cf9..623a210 100644
--- a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
+++ b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
@@ -326,11 +326,11 @@ class WorkerSourceTask extends WorkerTask {
// timeouts, callbacks with exceptions should never be invoked in practice. If the
// user overrode these settings, the best we can do is notify them of the failure via
// logging.
- log.error("{} failed to send record to {}: {}", this, topic, e);
- log.debug("{} Failed record: {}", this, preTransformRecord);
+ log.error("{} failed to send record to {}: {}", WorkerSourceTask.this, topic, e);
+ log.debug("{} Failed record: {}", WorkerSourceTask.this, preTransformRecord);
} else {
log.trace("{} Wrote record successfully: topic {} partition {} offset {}",
- this,
+ WorkerSourceTask.this,
recordMetadata.topic(), recordMetadata.partition(),
recordMetadata.offset());
commitTaskRecord(preTransformRecord);
@@ -454,9 +454,9 @@ class WorkerSourceTask extends WorkerTask {
@Override
public void onCompletion(Throwable error, Void result) {
if (error != null) {
- log.error("{} Failed to flush offsets to storage: ", this, error);
+ log.error("{} Failed to flush offsets to storage: ", WorkerSourceTask.this, error);
} else {
- log.trace("{} Finished flushing offsets to storage", this);
+ log.trace("{} Finished flushing offsets to storage", WorkerSourceTask.this);
}
}
});