[jira] [Commented] (ARTEMIS-1626) Disable thread leak check for failing tests

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334362#comment-16334362 ] 

ASF GitHub Bot commented on ARTEMIS-1626:
-----------------------------------------

GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1800

    ARTEMIS-1626 Disable thread leak check for failing tests

    The ThreadLeakCheckRule is used to check thread leaks
    after each test is finished. However when a test fails, it is
    not necessary to check leaking threads because the test
    failure should be fixed anyway. And leaking threads in a
    failed test may well be a result of the failure (once the test
    is fixed the thread leak may be gone).
    
    If a failed test also leaks threads, it takes a long time before
    the thread leak check finishes (60 seconds checking time),
    thus it takes a long time to finish, especially when tests are
    run in batches with failures.
    
    So to improve this, it should be reasonable to just enable
    the thread leaking check for each test passes, and disable
    the check when a test fails.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis fthread_rule

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1800.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1800
    
----
commit c8e25c72b9885bb08ec9dd5d8502c273b349d46a
Author: Howard Gao <ho...@...>
Date:   2018-01-22T14:39:23Z

    ARTEMIS-1626 Disable thread leak check for failing tests
    
    The ThreadLeakCheckRule is used to check thread leaks
    after each test is finished. However when a test fails, it is
    not necessary to check leaking threads because the test
    failure should be fixed anyway. And leaking threads in a
    failed test may well be a result of the failure (once the test
    is fixed the thread leak may be gone).
    
    If a failed test also leaks threads, it takes a long time before
    the thread leak check finishes (60 seconds checking time),
    thus it takes a long time to finish, especially when tests are
    run in batches with failures.
    
    So to improve this, it should be reasonable to just enable
    the thread leaking check for each test passes, and disable
    the check when a test fails.

----


> Disable thread leak check for failing tests
> -------------------------------------------
>
>                 Key: ARTEMIS-1626
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1626
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>            Priority: Major
>             Fix For: 2.5.0
>
>
> The ThreadLeakCheckRule is used to check thread leaks
> after each test is finished. However when a test fails, it is
> not necessary to check leaking threads because the test
> failure should be fixed anyway. And leaking threads in a
> failed test may well be a result of the failure (once the test
> is fixed the thread leak may be gone).
> If a failed test also leaks threads, it takes a long time before
> the thread leak check finishes (60 seconds checking time),
> thus it takes a long time to finish, especially when tests are
> run in batches with failures.
> So to improve this, it should be reasonable to just enable
> the thread leaking check for each test passes, and disable
> the check when a test fails.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)