[GitHub] [gobblin] Will-Lo commented on a diff in pull request #3664: [GOBBLIN-1804] Reject flow config updates that would fail compilation by returning service error

["Will-Lo (via GitHub)" <gi...@apache.org>]

Will-Lo commented on code in PR #3664:
URL: https://github.com/apache/gobblin/pull/3664#discussion_r1147961576


##########
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java:
##########
@@ -154,6 +154,53 @@ private String getErrorMessage(FlowSpec flowSpec) {
     }
     return "Could not form JSON in FlowConfigV2ResourceLocalHandler";
   }
+
+  /**
+   * Update flowConfig locally and trigger all listeners iff @param triggerListener is set to true
+   */
+  @Override
+  public UpdateResponse updateFlowConfig(FlowId flowId, FlowConfig flowConfig, boolean triggerListener, long modifiedWatermark) {

Review Comment:
   I think adding a response in the FlowConfigV2ResourceHandler is fine, this matches the same behavior of the create request which does the same thing, only checks for these errors in the V2 Handler.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org