You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "ezelkow1 (via GitHub)" <gi...@apache.org> on 2025/07/22 16:17:28 UTC
[PR] Fix nightly OS build issue - null stringview [trafficserver]
ezelkow1 opened a new pull request, #12379:
URL: https://github.com/apache/trafficserver/pull/12379
At some point this line changed from && to ||, so now both are evaluated and this is undefined when hostname is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix nightly OS build issue - null stringview [trafficserver]
Posted by "ezelkow1 (via GitHub)" <gi...@apache.org>.
ezelkow1 commented on PR #12379:
URL: https://github.com/apache/trafficserver/pull/12379#issuecomment-3103633453
@hnakamur Would appreciate any input since I think your PR changed this, if there's a reason we shouldnt change this back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix nightly OS build issue - null stringview [trafficserver]
Posted by "ezelkow1 (via GitHub)" <gi...@apache.org>.
ezelkow1 commented on PR #12379:
URL: https://github.com/apache/trafficserver/pull/12379#issuecomment-3104696903
[approve ci freebsd]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix nightly OS build issue - null stringview [trafficserver]
Posted by "ezelkow1 (via GitHub)" <gi...@apache.org>.
ezelkow1 merged PR #12379:
URL: https://github.com/apache/trafficserver/pull/12379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix nightly OS build issue - null stringview [trafficserver]
Posted by "ezelkow1 (via GitHub)" <gi...@apache.org>.
ezelkow1 commented on PR #12379:
URL: https://github.com/apache/trafficserver/pull/12379#issuecomment-3104689748
[approve ci FreeBSD]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix nightly OS build issue - null stringview [trafficserver]
Posted by "ezelkow1 (via GitHub)" <gi...@apache.org>.
ezelkow1 commented on PR #12379:
URL: https://github.com/apache/trafficserver/pull/12379#issuecomment-3104918320
[approve ci autest 1]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix nightly OS build issue - null stringview [trafficserver]
Posted by "hnakamur (via GitHub)" <gi...@apache.org>.
hnakamur commented on PR #12379:
URL: https://github.com/apache/trafficserver/pull/12379#issuecomment-3106073466
I confirmed I made a mistake at the commit .086847590ce708ccba0346fbdf06148a08db5b28.
@ezelkow1 Thank you for your fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org