You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/09/26 17:09:17 UTC

[GitHub] Mogball commented on a change in pull request #3530: Feature: memoized get_sqla_engine and some others

Mogball commented on a change in pull request #3530: Feature: memoized get_sqla_engine and some others
URL: https://github.com/apache/incubator-superset/pull/3530#discussion_r141121198
 
 

 ##########
 File path: superset/models/core.py
 ##########
 @@ -590,6 +590,8 @@ def set_sqlalchemy_uri(self, uri):
         conn.password = password_mask if conn.password else None
         self.sqlalchemy_uri = str(conn)  # hides the password
 
+    @utils.memoized(
 
 Review comment:
   That's what I thought as well, but without `watch` a good number of unit tests were failing/in error. Those are probably changing attributes to set up the tests instead of creating new objects.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services