You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/04 14:22:58 UTC
[GitHub] [arrow] pitrou opened a new pull request #10868: ARROW-13552: [C++] Remove deprecated APIs
pitrou opened a new pull request #10868:
URL: https://github.com/apache/arrow/pull/10868
Remove APIs that have been deprecated for long enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10868: ARROW-13552: [C++] Remove deprecated APIs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10868:
URL: https://github.com/apache/arrow/pull/10868#issuecomment-892762904
Revision: 64ebe00813ed841686f2983b7a2e03d5f1b2e8e1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-716](https://github.com/ursacomputing/crossbow/branches/all?query=actions-716)
|Task|Status|
|----|------|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-716-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-716-github-test-conda-cpp-valgrind)|
|test-debian-10-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-716-github-test-debian-10-cpp)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-716-github-test-fedora-33-cpp)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-716-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-716-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-716-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-716-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-716-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-716-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-716-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10868: ARROW-13552: [C++] Remove deprecated APIs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10868:
URL: https://github.com/apache/arrow/pull/10868#issuecomment-892708885
https://issues.apache.org/jira/browse/ARROW-13552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou edited a comment on pull request #10868: ARROW-13552: [C++] Remove deprecated APIs
Posted by GitBox <gi...@apache.org>.
pitrou edited a comment on pull request #10868:
URL: https://github.com/apache/arrow/pull/10868#issuecomment-892762061
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou edited a comment on pull request #10868: ARROW-13552: [C++] Remove deprecated APIs
Posted by GitBox <gi...@apache.org>.
pitrou edited a comment on pull request #10868:
URL: https://github.com/apache/arrow/pull/10868#issuecomment-892762061
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10868: ARROW-13552: [C++] Remove deprecated APIs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10868:
URL: https://github.com/apache/arrow/pull/10868#issuecomment-892708885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #10868: ARROW-13552: [C++] Remove deprecated APIs
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #10868:
URL: https://github.com/apache/arrow/pull/10868#discussion_r685800679
##########
File path: cpp/src/arrow/python/pyarrow.cc
##########
@@ -57,9 +57,6 @@ int import_pyarrow() {
} else { \
return UnwrapError(obj, #TYPE_NAME); \
} \
- } \
- Status unwrap_##FUNC_SUFFIX(PyObject* obj, std::shared_ptr<TYPE_NAME>* out) { \
- return unwrap_##FUNC_SUFFIX(obj).Value(out); \
Review comment:
This removal broke the turbodbc integration tests. Apparently turbodbc was still using the version with `*out`, eg at https://github.com/blue-yonder/turbodbc/blob/be96fef1450de9cd77a506fdce141dda563fd8b3/cpp/turbodbc_arrow/Library/src/set_arrow_parameters.cpp#L427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz closed pull request #10868: ARROW-13552: [C++] Remove deprecated APIs
Posted by GitBox <gi...@apache.org>.
bkietz closed pull request #10868:
URL: https://github.com/apache/arrow/pull/10868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10868: ARROW-13552: [C++] Remove deprecated APIs
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10868:
URL: https://github.com/apache/arrow/pull/10868#issuecomment-892762061
@github-actions submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz closed pull request #10868: ARROW-13552: [C++] Remove deprecated APIs
Posted by GitBox <gi...@apache.org>.
bkietz closed pull request #10868:
URL: https://github.com/apache/arrow/pull/10868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10868: ARROW-13552: [C++] Remove deprecated APIs
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10868:
URL: https://github.com/apache/arrow/pull/10868#issuecomment-892762061
@github-actions submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #10868: ARROW-13552: [C++] Remove deprecated APIs
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #10868:
URL: https://github.com/apache/arrow/pull/10868#discussion_r685805387
##########
File path: cpp/src/arrow/python/pyarrow.cc
##########
@@ -57,9 +57,6 @@ int import_pyarrow() {
} else { \
return UnwrapError(obj, #TYPE_NAME); \
} \
- } \
- Status unwrap_##FUNC_SUFFIX(PyObject* obj, std::shared_ptr<TYPE_NAME>* out) { \
- return unwrap_##FUNC_SUFFIX(obj).Value(out); \
Review comment:
Opened ARROW-13594 to track the build failure on our side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org