You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Erin Noe-Payne <er...@mitre.org> on 2012/08/27 18:13:15 UTC
Review Request: RAVE-770: popups respect preferredWidth & preferredHeight
module prefs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6784/
-----------------------------------------------------------
Review request for rave.
Description
-------
Update popups to respect module prefs preferredWidth and preferredWidth.
This addresses bug RAVE-770.
https://issues.apache.org/jira/browse/RAVE-770
Diffs
-----
trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1377685
trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1377685
trunk/rave-portal-resources/src/main/webapp/static/script/rave_opensocial.js 1377685
Diff: https://reviews.apache.org/r/6784/diff/
Testing
-------
Thanks,
Erin Noe-Payne
Re: Review Request: RAVE-770: popups respect preferredWidth &
preferredHeight module prefs
Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6784/#review10783
-----------------------------------------------------------
Ship it!
LGTM
- Anthony Carlucci
On Aug. 27, 2012, 4:13 p.m., Erin Noe-Payne wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6784/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2012, 4:13 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Update popups to respect module prefs preferredWidth and preferredWidth.
>
>
> This addresses bug RAVE-770.
> https://issues.apache.org/jira/browse/RAVE-770
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1377685
> trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1377685
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_opensocial.js 1377685
>
> Diff: https://reviews.apache.org/r/6784/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erin Noe-Payne
>
>