You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/17 05:16:09 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request, #9795: Improve Kubernetes Pod lister with field selector
kezhenxu94 opened a new pull request, #9795:
URL: https://github.com/apache/skywalking/pull/9795
I think I had been trapped in the thoughts that we need to list all resources (Pods, services, etc.) and recompose them in memory, recently when I am reviewing the codes, I found that we can simply list/fetch the exact resource by just namespace/name.
In this patch I improve the logic to fetch the Pod by IP with field selector, this prevents us to listing all Pods and then filter in memory.
The usage of other resources can not be improved that much as they don't have suitable filed selector supported for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #9795: Improve Kubernetes Pod lister with field selector
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #9795:
URL: https://github.com/apache/skywalking/pull/9795#issuecomment-1280729021
> That is why I mentioned pro and con. The pro is, you could read less data, the con is the first few traffic has to be missed.
>
Hi. When the first traffic request access log comes to skywalking, skywalking reads the Pods by IP and do the analysis, why do you say the first few traffic will be missed? Did I miss anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #9795: Improve Kubernetes Pod lister with field selector
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #9795:
URL: https://github.com/apache/skywalking/pull/9795#issuecomment-1280314071
> Filtering pods through IPs mean we have to wait for traffic of pods, and wait for next round fetching?
> I think this would have pro and con effects.
Not the next round fetching. It will fetch (and wait) when the first traffic request comes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sonatype-lift[bot] commented on a diff in pull request #9795: Improve Kubernetes Pod lister with field selector
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on code in PR #9795:
URL: https://github.com/apache/skywalking/pull/9795#discussion_r996637642
##########
oap-server/server-library/library-kubernetes-support/src/main/java/org/apache/skywalking/library/kubernetes/ObjectID.java:
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+ package org.apache.skywalking.library.kubernetes;
+
+import org.apache.logging.log4j.util.Strings;
+import lombok.Builder;
+import lombok.Data;
+import lombok.RequiredArgsConstructor;
+import lombok.experimental.Accessors;
+
+@Data
+@Builder
Review Comment:
*[CanIgnoreReturnValueSuggester](https://errorprone.info/bugpattern/CanIgnoreReturnValueSuggester):* Methods that always 'return this' should be annotated with @CanIgnoreReturnValue
---
```suggestion
@CanIgnoreReturnValue
```
---
<details><summary><b>βΉοΈ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [π Not relevant](https://www.sonatype.com/lift-comment-rating?comment=345551208&lift_comment_rating=1) ] - [ [π Won't fix](https://www.sonatype.com/lift-comment-rating?comment=345551208&lift_comment_rating=2) ] - [ [π Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=345551208&lift_comment_rating=3) ] - [ [π Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=345551208&lift_comment_rating=4) ] - [ [π Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=345551208&lift_comment_rating=5) ]
##########
oap-server/server-library/library-kubernetes-support/src/main/java/org/apache/skywalking/library/kubernetes/KubernetesPods.java:
##########
@@ -20,21 +20,21 @@
package org.apache.skywalking.library.kubernetes;
import java.time.Duration;
-import java.util.Collections;
-import java.util.List;
-import org.slf4j.LoggerFactory;
+import java.util.Optional;
import com.google.common.cache.CacheBuilder;
import com.google.common.cache.CacheLoader;
import com.google.common.cache.LoadingCache;
-import io.kubernetes.client.openapi.ApiException;
import io.kubernetes.client.openapi.apis.CoreV1Api;
import io.kubernetes.client.openapi.models.V1Pod;
import lombok.SneakyThrows;
public enum KubernetesPods {
INSTANCE;
- private final LoadingCache<KubernetesPods, List<V1Pod>> pods;
+ private static final String FIELD_SELECTOR_PATTERN_POD_IP = "status.podIP=%s";
Review Comment:
*[InlineFormatString](https://errorprone.info/bugpattern/InlineFormatString):* Prefer to create format strings inline, instead of extracting them to a single-use constant
---
<details><summary><b>βΉοΈ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [π Not relevant](https://www.sonatype.com/lift-comment-rating?comment=345551268&lift_comment_rating=1) ] - [ [π Won't fix](https://www.sonatype.com/lift-comment-rating?comment=345551268&lift_comment_rating=2) ] - [ [π Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=345551268&lift_comment_rating=3) ] - [ [π Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=345551268&lift_comment_rating=4) ] - [ [π Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=345551268&lift_comment_rating=5) ]
##########
oap-server/server-library/library-kubernetes-support/src/main/java/org/apache/skywalking/library/kubernetes/ObjectID.java:
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+ package org.apache.skywalking.library.kubernetes;
+
+import org.apache.logging.log4j.util.Strings;
+import lombok.Builder;
+import lombok.Data;
+import lombok.RequiredArgsConstructor;
+import lombok.experimental.Accessors;
+
+@Data
+@Builder
+@RequiredArgsConstructor
+@Accessors(fluent = true)
+public class ObjectID {
+ public static final ObjectID EMPTY = ObjectID.builder().build();
+
+ private final String name;
+ private final String namespace;
+
+ @Override
+ public String toString() {
+ if (this == EMPTY) {
Review Comment:
*[ReferenceEquality](https://errorprone.info/bugpattern/ReferenceEquality):* Comparison using reference equality instead of value equality
---
```suggestion
if (this.equals(EMPTY)) {
```
---
<details><summary><b>βΉοΈ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [π Not relevant](https://www.sonatype.com/lift-comment-rating?comment=345551245&lift_comment_rating=1) ] - [ [π Won't fix](https://www.sonatype.com/lift-comment-rating?comment=345551245&lift_comment_rating=2) ] - [ [π Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=345551245&lift_comment_rating=3) ] - [ [π Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=345551245&lift_comment_rating=4) ] - [ [π Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=345551245&lift_comment_rating=5) ]
##########
oap-server/server-library/library-kubernetes-support/src/main/java/org/apache/skywalking/library/kubernetes/KubernetesPods.java:
##########
@@ -20,21 +20,21 @@
package org.apache.skywalking.library.kubernetes;
import java.time.Duration;
-import java.util.Collections;
-import java.util.List;
-import org.slf4j.LoggerFactory;
+import java.util.Optional;
import com.google.common.cache.CacheBuilder;
import com.google.common.cache.CacheLoader;
import com.google.common.cache.LoadingCache;
-import io.kubernetes.client.openapi.ApiException;
import io.kubernetes.client.openapi.apis.CoreV1Api;
import io.kubernetes.client.openapi.models.V1Pod;
import lombok.SneakyThrows;
public enum KubernetesPods {
INSTANCE;
- private final LoadingCache<KubernetesPods, List<V1Pod>> pods;
+ private static final String FIELD_SELECTOR_PATTERN_POD_IP = "status.podIP=%s";
+
+ private final LoadingCache<String, Optional<V1Pod>> podByIP;
+ private final LoadingCache<ObjectID, Optional<V1Pod>> podByObjectID;
Review Comment:
π¬ 2 similar findings have been found in this PR
---
*[ImmutableEnumChecker](https://errorprone.info/bugpattern/ImmutableEnumChecker):* enums should be immutable: 'KubernetesPods' has field 'podByObjectID' of type 'com.google.common.cache.LoadingCache<org.apache.skywalking.library.kubernetes.ObjectID,java.util.Optional<io.kubernetes.client.openapi.models.V1Pod>>', the declaration of type 'com.google.common.cache.LoadingCache<org.apache.skywalking.library.kubernetes.ObjectID,java.util.Optional<io.kubernetes.client.openapi.models.V1Pod>>' is not annotated with @com.google.errorprone.annotations.Immutable
---
<details><summary><b>π Expand here to view all instances of this finding</b></summary><br/>
<div align="center">
| **File Path** | **Line Number** |
| ------------- | ------------- |
| oap-server/server-library/library-kubernetes-support/src/main/java/org/apache/skywalking/library/kubernetes/KubernetesServices.java | [39](https://github.com/kezhenxu94/skywalking/blob/041f3784ccd3b4b59d29eb8233b384cc9bb67187/oap-server/server-library/library-kubernetes-support/src/main/java/org/apache/skywalking/library/kubernetes/KubernetesServices.java#L39)|
| oap-server/server-library/library-kubernetes-support/src/main/java/org/apache/skywalking/library/kubernetes/KubernetesPods.java | [36](https://github.com/kezhenxu94/skywalking/blob/041f3784ccd3b4b59d29eb8233b384cc9bb67187/oap-server/server-library/library-kubernetes-support/src/main/java/org/apache/skywalking/library/kubernetes/KubernetesPods.java#L36)|
<p><a href="https://lift.sonatype.com/results/github.com/apache/skywalking/01GFJ5YYBMCWQQGQDYXHWR0FX2?t=ErrorProne|ImmutableEnumChecker" target="_blank">Visit the Lift Web Console</a> to find more details in your report.</p></div></details>
---
<details><summary><b>βΉοΈ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [π Not relevant](https://www.sonatype.com/lift-comment-rating?comment=345551073&lift_comment_rating=1) ] - [ [π Won't fix](https://www.sonatype.com/lift-comment-rating?comment=345551073&lift_comment_rating=2) ] - [ [π Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=345551073&lift_comment_rating=3) ] - [ [π Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=345551073&lift_comment_rating=4) ] - [ [π Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=345551073&lift_comment_rating=5) ]
##########
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/k8s/K8SServiceRegistry.java:
##########
@@ -121,7 +115,11 @@ public ServiceMetaInfo load(String ip) throws Exception {
.filter(subset -> subset.getAddresses() != null)
.flatMap(subset -> subset.getAddresses().stream())
Review Comment:
π¬ 2 similar findings have been found in this PR
---
*NULL_DEREFERENCE:* object returned by `subset.getAddresses()` could be null and is dereferenced at line 116.
---
<details><summary><b>π Expand here to view all instances of this finding</b></summary><br/>
<div align="center">
| **File Path** | **Line Number** |
| ------------- | ------------- |
| oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java | [71](https://github.com/kezhenxu94/skywalking/blob/041f3784ccd3b4b59d29eb8233b384cc9bb67187/oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java#L71)|
| oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java | [50](https://github.com/kezhenxu94/skywalking/blob/041f3784ccd3b4b59d29eb8233b384cc9bb67187/oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java#L50)|
<p><a href="https://lift.sonatype.com/results/github.com/apache/skywalking/01GFJ5YYBMCWQQGQDYXHWR0FX2?t=Infer|NULL_DEREFERENCE" target="_blank">Visit the Lift Web Console</a> to find more details in your report.</p></div></details>
---
<details><summary><b>βΉοΈ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [π Not relevant](https://www.sonatype.com/lift-comment-rating?comment=345551379&lift_comment_rating=1) ] - [ [π Won't fix](https://www.sonatype.com/lift-comment-rating?comment=345551379&lift_comment_rating=2) ] - [ [π Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=345551379&lift_comment_rating=3) ] - [ [π Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=345551379&lift_comment_rating=4) ] - [ [π Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=345551379&lift_comment_rating=5) ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #9795: Improve Kubernetes Pod lister with field selector
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #9795:
URL: https://github.com/apache/skywalking/pull/9795#issuecomment-1280428043
> > > So, we must lose the first seconds data, even the pod is up for a while. Considering business booting takes 20-30s at least, we nearly don't lose data before.
> >
> >
> > Sounds like you miss something. Even if the app container takes some time to boot, users should have configured healthiness check and readiness check so if the app containers is not ready no requests will be routed to the pod
>
> My question is mainly about when pod1(IP-A) boots and is standing by, but no request, would OAP get the IP-pod-deployment mapping?
No. this case is what I want to improved, itβs unnecessary to fetch this Pod mapping right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #9795: Improve Kubernetes Pod lister with field selector
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #9795:
URL: https://github.com/apache/skywalking/pull/9795#issuecomment-1280738324
> I thought you would read pod IP in async way.
No, not read the Pods asynchronously, just like before: lazy load the Pod info only when necessary, but with field selector to only fetch needed Pod.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9795: Improve Kubernetes Pod lister with field selector
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9795:
URL: https://github.com/apache/skywalking/pull/9795#issuecomment-1280378349
> > So, we must lose the first seconds data, even the pod is up for a while. Considering business booting takes 20-30s at least, we nearly don't lose data before.
>
> Sounds like you miss something. Even if the app container takes some time to boot, users should have configured healthiness check and readiness check so if the app containers is not ready no requests will be routed to the pod
My question is mainly about when pod1(IP-A) boots and is standing by, but no request, would OAP get the IP-pod-deployment mapping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9795: Improve Kubernetes Pod lister with field selector
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9795:
URL: https://github.com/apache/skywalking/pull/9795#issuecomment-1280317252
So, we must lose the first seconds data, even the pod is up for a while. Considering business booting takes 20-30s at least, we nearly don't lose data before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9795: Improve Kubernetes Pod lister with field selector
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9795:
URL: https://github.com/apache/skywalking/pull/9795#issuecomment-1280308882
Filtering pods through IPs mean we have to wait for traffic of pods, and wait for next round fetching?
I think this would have pro and con effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #9795: Improve Kubernetes Pod lister with field selector
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #9795:
URL: https://github.com/apache/skywalking/pull/9795#issuecomment-1280324731
> So, we must lose the first seconds data, even the pod is up for a while. Considering business booting takes 20-30s at least, we nearly don't lose data before.
Sounds like you miss something. Even if the app container takes some time to boot, users should have configured healthiness check and readiness check so if the app containers is not ready no requests will be routed to the pod
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9795: Improve Kubernetes Pod lister with field selector
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9795:
URL: https://github.com/apache/skywalking/pull/9795#issuecomment-1280733574
I thought you would read pod IP in async way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9795: Improve Kubernetes Pod lister with field selector
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9795:
URL: https://github.com/apache/skywalking/pull/9795#issuecomment-1280454488
> > > > So, we must lose the first seconds data, even the pod is up for a while. Considering business booting takes 20-30s at least, we nearly don't lose data before.
> > >
> > >
> > > Sounds like you miss something. Even if the app container takes some time to boot, users should have configured healthiness check and readiness check so if the app containers is not ready no requests will be routed to the pod
> >
> >
> > My question is mainly about when pod1(IP-A) boots and is standing by, but no request, would OAP get the IP-pod-deployment mapping?
>
> No. this case is what I want to improved, itβs unnecessary to fetch this Pod mapping right?
That is why I mentioned pro and con. The pro is, you could read less data, the con is the first few traffic has to be missed.
I don't have a preference for now, but I suppose this is worth thinking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sonatype-lift[bot] commented on pull request #9795: Improve Kubernetes Pod lister with field selector
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on PR #9795:
URL: https://github.com/apache/skywalking/pull/9795#issuecomment-1280325016
:warning: **6 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/skywalking/01GFJ5XTY69ZZN7GDTSDH91NX4?tab=technical-debt&utm_source=github.com&utm_campaign=lift-comment&utm_content=apache\%20skywalking) for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9795: Improve Kubernetes Pod lister with field selector
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9795:
URL: https://github.com/apache/skywalking/pull/9795#issuecomment-1280784584
Got it, make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #9795: Improve Kubernetes Pod lister with field selector
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #9795:
URL: https://github.com/apache/skywalking/pull/9795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org