You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Shazron <sh...@gmail.com> on 2012/03/24 00:03:49 UTC

cordova-js version inside the file

... just like jQuery. Thoughts? Filename is enough?

The way I did it from before in iOS was replace a known token inside
the .js file with the version.

Re: cordova-js version inside the file

Posted by Shazron <sh...@gmail.com>.
Seems like a consensus - I'll probably add a comment block at the top
with a known token that you can replace (or two, for platform as well)
- important for iOS version replacement since it is automated, not
manual.

On Sat, Mar 24, 2012 at 12:42 AM, Jesse <pu...@gmail.com> wrote:
> +1
> Also, the platform it was built for may make sense as well, so you can
> easily open the file and isolate an issue of someone using an Android exec
> in an iOS app .. ( which seems to happen a lot )
>
>
>
> On Fri, Mar 23, 2012 at 11:04 PM, Brian LeRoux <b...@brian.io> wrote:
>
>> +1
>>
>> On Fri, Mar 23, 2012 at 9:04 PM, Bryce Curtis <cu...@gmail.com>
>> wrote:
>> > I'm in favor of having the version inside - some integrators rename the
>> JS
>> > file, so having the version inside would be useful.
>> >
>> > It might be good to for corova-js init code to compare JS with native to
>> > verify they are the same version - and alert the user if not.
>> >
>> > On Fri, Mar 23, 2012 at 6:03 PM, Shazron <sh...@gmail.com> wrote:
>> >
>> >> ... just like jQuery. Thoughts? Filename is enough?
>> >>
>> >> The way I did it from before in iOS was replace a known token inside
>> >> the .js file with the version.
>> >>
>>

Re: cordova-js version inside the file

Posted by Filip Maj <fi...@adobe.com>.
I've added this to JIRA https://issues.apache.org/jira/browse/CB-385

On 3/24/12 12:42 AM, "Jesse" <pu...@gmail.com> wrote:

>+1
>Also, the platform it was built for may make sense as well, so you can
>easily open the file and isolate an issue of someone using an Android exec
>in an iOS app .. ( which seems to happen a lot )
>
>
>
>On Fri, Mar 23, 2012 at 11:04 PM, Brian LeRoux <b...@brian.io> wrote:
>
>> +1
>>
>> On Fri, Mar 23, 2012 at 9:04 PM, Bryce Curtis <cu...@gmail.com>
>> wrote:
>> > I'm in favor of having the version inside - some integrators rename
>>the
>> JS
>> > file, so having the version inside would be useful.
>> >
>> > It might be good to for corova-js init code to compare JS with native
>>to
>> > verify they are the same version - and alert the user if not.
>> >
>> > On Fri, Mar 23, 2012 at 6:03 PM, Shazron <sh...@gmail.com> wrote:
>> >
>> >> ... just like jQuery. Thoughts? Filename is enough?
>> >>
>> >> The way I did it from before in iOS was replace a known token inside
>> >> the .js file with the version.
>> >>
>>


Re: cordova-js version inside the file

Posted by Jesse <pu...@gmail.com>.
+1
Also, the platform it was built for may make sense as well, so you can
easily open the file and isolate an issue of someone using an Android exec
in an iOS app .. ( which seems to happen a lot )



On Fri, Mar 23, 2012 at 11:04 PM, Brian LeRoux <b...@brian.io> wrote:

> +1
>
> On Fri, Mar 23, 2012 at 9:04 PM, Bryce Curtis <cu...@gmail.com>
> wrote:
> > I'm in favor of having the version inside - some integrators rename the
> JS
> > file, so having the version inside would be useful.
> >
> > It might be good to for corova-js init code to compare JS with native to
> > verify they are the same version - and alert the user if not.
> >
> > On Fri, Mar 23, 2012 at 6:03 PM, Shazron <sh...@gmail.com> wrote:
> >
> >> ... just like jQuery. Thoughts? Filename is enough?
> >>
> >> The way I did it from before in iOS was replace a known token inside
> >> the .js file with the version.
> >>
>

Re: cordova-js version inside the file

Posted by Brian LeRoux <b...@brian.io>.
+1

On Fri, Mar 23, 2012 at 9:04 PM, Bryce Curtis <cu...@gmail.com> wrote:
> I'm in favor of having the version inside - some integrators rename the JS
> file, so having the version inside would be useful.
>
> It might be good to for corova-js init code to compare JS with native to
> verify they are the same version - and alert the user if not.
>
> On Fri, Mar 23, 2012 at 6:03 PM, Shazron <sh...@gmail.com> wrote:
>
>> ... just like jQuery. Thoughts? Filename is enough?
>>
>> The way I did it from before in iOS was replace a known token inside
>> the .js file with the version.
>>

Re: cordova-js version inside the file

Posted by Bryce Curtis <cu...@gmail.com>.
I'm in favor of having the version inside - some integrators rename the JS
file, so having the version inside would be useful.

It might be good to for corova-js init code to compare JS with native to
verify they are the same version - and alert the user if not.

On Fri, Mar 23, 2012 at 6:03 PM, Shazron <sh...@gmail.com> wrote:

> ... just like jQuery. Thoughts? Filename is enough?
>
> The way I did it from before in iOS was replace a known token inside
> the .js file with the version.
>