Re: [PR] [SPARK-45959][SQL] : Deduplication of relations causes ambiguous exception to be raised, though logically it is Unambiguous [spark]

["ahshahid (via GitHub)" <gi...@apache.org>]

ahshahid commented on PR #45343:
URL: https://github.com/apache/spark/pull/45343#issuecomment-1982020269

   While fixing the issue, found that tests in DataFrameSelfJoinSuite, where the two legs have distinct datasetId , the tests are expecting AnalysisException due to ambiguity in the join condition, which IMO is not correct as it is possible to dis-ambiguate using resolution via Dataset ID.
   This PR fixes the above and have test modifications accordingly.
   The same applies to some tests in DataFrameAsofJoinSuite.
   I believe there is still need to do some enhancement  in the existing  source code related to AsofJoin, as the condition part is still not trying to disambiguate properly ( unlike the changes done for Join). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org