[GitHub] [dubbo] jojocodeX commented on a diff in pull request #11756: metrics dependencies change

["jojocodeX (via GitHub)" <gi...@apache.org>]

jojocodeX commented on code in PR #11756:
URL: https://github.com/apache/dubbo/pull/11756#discussion_r1128773977


##########
dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/filter/DefaultFilterChainBuilderTest.java:
##########
@@ -64,7 +64,7 @@ protected Result doInvoke(Invocation invocation) {
         };
         invokerAfterBuild = defaultFilterChainBuilder.buildInvokerChain(invokerWithFilter, REFERENCE_FILTER_KEY, CONSUMER);
         Assertions.assertTrue(invokerAfterBuild instanceof FilterChainBuilder.CallbackRegistrationInvoker);
-        Assertions.assertEquals(1, ((FilterChainBuilder.CallbackRegistrationInvoker<?, ?>) invokerAfterBuild).filters.size());
+//        Assertions.assertEquals(1, ((FilterChainBuilder.CallbackRegistrationInvoker<?, ?>) invokerAfterBuild).filters.size());

Review Comment:
   handle unused code



##########
dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/filter/DefaultFilterChainBuilderTest.java:
##########
@@ -49,7 +49,7 @@ protected Result doInvoke(Invocation invocation) {
         };
 
         Invoker<?> invokerAfterBuild = defaultFilterChainBuilder.buildInvokerChain(invokerWithoutFilter, REFERENCE_FILTER_KEY, CONSUMER);
-        Assertions.assertTrue(invokerAfterBuild instanceof AbstractInvoker);
+//        Assertions.assertTrue(invokerAfterBuild instanceof AbstractInvoker);

Review Comment:
   handle unused code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org