You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "clayburn (via GitHub)" <gi...@apache.org> on 2023/05/03 11:46:31 UTC
[GitHub] [pulsar] clayburn opened a new pull request, #20218: [improve][ci] Replace handmade action to configure Gradle Enterprise
clayburn opened a new pull request, #20218:
URL: https://github.com/apache/pulsar/pull/20218
### Motivation
<!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
After the PR https://github.com/apache/pulsar/pull/20187, the custom action at `.github/actions/gradle-enterprise/action.yml` simply sets the `GRADLE_ENTERPRISE_ACCESS_KEY` environment variable. Since this is the only step performed by this action, it makes sense to remove it to simplify workflows.
This was mentioned in the review for https://github.com/apache/pulsar/pull/20187: https://github.com/apache/pulsar/pull/20187#pullrequestreview-1406899559
### Modifications
- Remove the custom `gradle-enterprise` action
- Use the built in `env` configuration to set the `GRADLE_ENTERPRISE_ACCESS_KEY` where needed
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #20218: [improve][ci] Replace handmade action to configure Gradle Enterprise
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #20218:
URL: https://github.com/apache/pulsar/pull/20218#issuecomment-1532886641
Thanks for taking care of this @clayburn!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20218: [improve][ci] Replace handmade action to configure Gradle Enterprise
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20218:
URL: https://github.com/apache/pulsar/pull/20218#issuecomment-1534547629
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20218?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20218](https://app.codecov.io/gh/apache/pulsar/pull/20218?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eec8562) into [master](https://app.codecov.io/gh/apache/pulsar/commit/a22700df665a9ea0a8db98334b6d4337e5e490f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a22700d) will **increase** coverage by `35.25%`.
> The diff coverage is `n/a`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #20218 +/- ##
=============================================
+ Coverage 37.66% 72.92% +35.25%
- Complexity 345 31952 +31607
=============================================
Files 1691 1868 +177
Lines 129004 138539 +9535
Branches 14071 15246 +1175
=============================================
+ Hits 48592 101028 +52436
+ Misses 74114 29469 -44645
- Partials 6298 8042 +1744
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.19% <ø> (-0.03%)` | :arrow_down: |
| systests | `24.76% <ø> (-0.12%)` | :arrow_down: |
| unittests | `72.21% <ø> (+39.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1430 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20218/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] clayburn commented on pull request #20218: [improve][ci] Replace handmade action to configure Gradle Enterprise
Posted by "clayburn (via GitHub)" <gi...@apache.org>.
clayburn commented on PR #20218:
URL: https://github.com/apache/pulsar/pull/20218#issuecomment-1532891666
> Thanks for taking care of this @clayburn!
No problem @tisonkun! Very fast approval, before I could even add a couple of explanatory comments 🙂.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #20218: [improve][ci] Replace handmade action to configure Gradle Enterprise
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #20218:
URL: https://github.com/apache/pulsar/pull/20218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] clayburn commented on a diff in pull request #20218: [improve][ci] Replace handmade action to configure Gradle Enterprise
Posted by "clayburn (via GitHub)" <gi...@apache.org>.
clayburn commented on code in PR #20218:
URL: https://github.com/apache/pulsar/pull/20218#discussion_r1183582313
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -721,11 +706,6 @@ jobs:
- name: Tune Runner VM
uses: ./.github/actions/tune-runner-vm
- - name: Configure Gradle Enterprise
Review Comment:
I don't believe this was needed. This job does not seem to run a Maven build.
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -1208,11 +1177,6 @@ jobs:
- name: Tune Runner VM
uses: ./.github/actions/tune-runner-vm
- - name: Configure Gradle Enterprise
Review Comment:
I don't believe this was needed. This job does not seem to run a Maven build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #20218: [improve][ci] Replace handmade action to configure Gradle Enterprise
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #20218:
URL: https://github.com/apache/pulsar/pull/20218#issuecomment-1534452820
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org