[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #457: [ISSUE-455] Lazily create uncompressedData

[GitBox <gi...@apache.org>]

zuston commented on code in PR #457:
URL: https://github.com/apache/incubator-uniffle/pull/457#discussion_r1062293906


##########
client-spark/common/src/main/java/org/apache/spark/shuffle/reader/RssShuffleDataIterator.java:
##########
@@ -69,13 +70,7 @@ public RssShuffleDataIterator(
     this.shuffleReadClient = shuffleReadClient;
     this.shuffleReadMetrics = shuffleReadMetrics;
     this.codec = Codec.newInstance(rssConf);
-    // todo: support off-heap bytebuffer
-    this.uncompressedData = ByteBuffer.allocate(
-        (int) rssConf.getSizeAsBytes(
-            RssClientConfig.RSS_WRITER_BUFFER_SIZE,

Review Comment:
   Yes, we should remove this. The concept of RSS_WRITER_BUFFER_SIZE is the threshold of writing buffer, which is not related with reading buffer.
   
   In this PR, we just need to remove this part logic. WDYT? @xianjingfeng 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org