You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2015/05/01 00:01:14 UTC
Re: Review Request 33655: Full Delete of Host : Fix UpgradeCatalogs to
handle host-related changes in 1.6.1, 1.7.0,
and 2.0.0 after refactoring Entity models
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33655/
-----------------------------------------------------------
(Updated April 30, 2015, 10:01 p.m.)
Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-10170
https://issues.apache.org/jira/browse/AMBARI-10170
Repository: ambari
Description
-------
The older upgrade catalogs cannot use any of Entity models that are related to the hosts table because the host_name is no longer present (instead the host_id).
For this reason, I changed the UpgradeCatalogs to use raw SQL.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 940be93
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 1d6095b
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog.java f482dc2
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java 03b995a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java cd3945a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java ac32081
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java ac8bb52
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 23ffad0
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 4117a1c
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java c7866db
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java d150d76
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogTest.java eb53b03
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeTest.java b9b01f8
Diff: https://reviews.apache.org/r/33655/diff/
Testing
-------
Created VMs with each of the following Ambari versions and tested these upgrade paths.
2.0.0 -> 2.1.0 (has known issues due to XML properties)
1.7.0 -> 2.0.0 -> 2.1.0 (has known issues due to the stacks table, this removed Nagios service, which was tested in UpgradeCatalog200)
1.6.1 -> 1.7.0 -> 2.0.0 -> 2.1.0 (has known issues due to the stacks table, this updated the host_role_command table, which was tested in UpgradeCatalog170)
1.6.0 -> 1.6.1 -> 1.7.0 -> 2.0.0 -> 2.1.0
To get these work, I had to comment out certain functions that are known to fail today.
I ran local unit tests on ambari-server/src/test/java/org/apache/ambari/server/upgrade and they passed.
Thanks,
Alejandro Fernandez
Re: Review Request 33655: Full Delete of Host : Fix UpgradeCatalogs to
handle host-related changes in 1.6.1, 1.7.0,
and 2.0.0 after refactoring Entity models
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33655/#review82243
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On April 30, 2015, 6:02 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33655/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 6:02 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-10170
> https://issues.apache.org/jira/browse/AMBARI-10170
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Throughout refactoring the host_name => host_id changes, the UpgradeCatalogs wouldn't work due to the host-entities not being correct. Now that they are are finalized with the Foreign Keys, the UpgradeCatalogs don't generate any host errors any longer.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 940be93
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 1d6095b
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog.java f482dc2
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java 03b995a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java cd3945a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java ac32081
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java ac8bb52
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 23ffad0
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 4117a1c
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java c7866db
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java d150d76
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogTest.java eb53b03
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeTest.java b9b01f8
>
> Diff: https://reviews.apache.org/r/33655/diff/
>
>
> Testing
> -------
>
> Created VMs with each of the following Ambari versions and tested these upgrade paths.
> 2.0.0 -> 2.1.0 (has known issues due to XML properties)
> 1.7.0 -> 2.0.0 -> 2.1.0 (has known issues due to the stacks table, this removed Nagios service, which was tested in UpgradeCatalog200)
> 1.6.1 -> 1.7.0 -> 2.0.0 -> 2.1.0 (has known issues due to the stacks table, this updated the host_role_command table, which was tested in UpgradeCatalog170)
> 1.6.0 -> 1.6.1 -> 1.7.0 -> 2.0.0 -> 2.1.0
>
> To get these work, I had to comment out certain functions that are known to fail today.
>
> I ran local unit tests on ambari-server/src/test/java/org/apache/ambari/server/upgrade and they passed.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 33655: Full Delete of Host : Fix UpgradeCatalogs to
handle host-related changes in 1.6.1, 1.7.0,
and 2.0.0 after refactoring Entity models
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33655/#review82208
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
<https://reviews.apache.org/r/33655/#comment132905>
No longer needed.
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
<https://reviews.apache.org/r/33655/#comment132906>
In UpgradeCatalog210, this is used for the stacks.
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogTest.java
<https://reviews.apache.org/r/33655/#comment132907>
Test case is no longer needed.
- Alejandro Fernandez
On April 30, 2015, 10:02 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33655/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 10:02 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-10170
> https://issues.apache.org/jira/browse/AMBARI-10170
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Throughout refactoring the host_name => host_id changes, the UpgradeCatalogs wouldn't work due to the host-entities not being correct. Now that they are are finalized with the Foreign Keys, the UpgradeCatalogs don't generate any host errors any longer.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 940be93
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 1d6095b
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog.java f482dc2
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java 03b995a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java cd3945a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java ac32081
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java ac8bb52
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 23ffad0
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 4117a1c
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java c7866db
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java d150d76
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogTest.java eb53b03
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeTest.java b9b01f8
>
> Diff: https://reviews.apache.org/r/33655/diff/
>
>
> Testing
> -------
>
> Created VMs with each of the following Ambari versions and tested these upgrade paths.
> 2.0.0 -> 2.1.0 (has known issues due to XML properties)
> 1.7.0 -> 2.0.0 -> 2.1.0 (has known issues due to the stacks table, this removed Nagios service, which was tested in UpgradeCatalog200)
> 1.6.1 -> 1.7.0 -> 2.0.0 -> 2.1.0 (has known issues due to the stacks table, this updated the host_role_command table, which was tested in UpgradeCatalog170)
> 1.6.0 -> 1.6.1 -> 1.7.0 -> 2.0.0 -> 2.1.0
>
> To get these work, I had to comment out certain functions that are known to fail today.
>
> I ran local unit tests on ambari-server/src/test/java/org/apache/ambari/server/upgrade and they passed.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 33655: Full Delete of Host : Fix UpgradeCatalogs to
handle host-related changes in 1.6.1, 1.7.0,
and 2.0.0 after refactoring Entity models
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33655/
-----------------------------------------------------------
(Updated April 30, 2015, 10:02 p.m.)
Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-10170
https://issues.apache.org/jira/browse/AMBARI-10170
Repository: ambari
Description (updated)
-------
Throughout refactoring the host_name => host_id changes, the UpgradeCatalogs wouldn't work due to the host-entities not being correct. Now that they are are finalized with the Foreign Keys, the UpgradeCatalogs don't generate any host errors any longer.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 940be93
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 1d6095b
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog.java f482dc2
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java 03b995a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java cd3945a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java ac32081
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java ac8bb52
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 23ffad0
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 4117a1c
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java c7866db
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java d150d76
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogTest.java eb53b03
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeTest.java b9b01f8
Diff: https://reviews.apache.org/r/33655/diff/
Testing
-------
Created VMs with each of the following Ambari versions and tested these upgrade paths.
2.0.0 -> 2.1.0 (has known issues due to XML properties)
1.7.0 -> 2.0.0 -> 2.1.0 (has known issues due to the stacks table, this removed Nagios service, which was tested in UpgradeCatalog200)
1.6.1 -> 1.7.0 -> 2.0.0 -> 2.1.0 (has known issues due to the stacks table, this updated the host_role_command table, which was tested in UpgradeCatalog170)
1.6.0 -> 1.6.1 -> 1.7.0 -> 2.0.0 -> 2.1.0
To get these work, I had to comment out certain functions that are known to fail today.
I ran local unit tests on ambari-server/src/test/java/org/apache/ambari/server/upgrade and they passed.
Thanks,
Alejandro Fernandez