You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by ilooner-mapr <gi...@git.apache.org> on 2017/08/17 23:39:08 UTC
[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build
GitHub user ilooner-mapr opened a pull request:
https://github.com/apache/drill/pull/913
- DRILL-5729 Fix Travis Build
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilooner-mapr/drill DRILL-5729
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/913.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #913
----
commit b52188f8091a3b22021cb1efaa42f7ebb1b2792d
Author: Timothy Farkas <ti...@apache.org>
Date: 2017-08-17T23:37:24Z
- DRILL-5729 explicitly made the travis container ubuntu precise to fix build errors caused by ubuntu trusty.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Posted by ilooner <gi...@git.apache.org>.
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/913
@parthchandra I think the PR still needs a +1 from a committer. If Vlad's review is sufficient, could you give this a +1?
Thanks,
Tim
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/913
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build
Posted by ilooner-mapr <gi...@git.apache.org>.
Github user ilooner-mapr commented on a diff in the pull request:
https://github.com/apache/drill/pull/913#discussion_r135312783
--- Diff: .travis.yml ---
@@ -13,8 +13,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-sudo: false
before_install: git fetch --unshallow
language: java
-install: mvn install --batch-mode -DskipTests=true -Dmaven.javadoc.skip=true -Dsource.skip=true > mvn_install.log || (cat mvn_install.log && false)
-script: mvn package -DskipTests=true
+jdk:
+ - openjdk7
--- End diff --
Hmm good to know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/913
@ilooner-mapr Do you know why it fails on the Trusty (new default)? Going back to using Precise is OK for a while, but my guess that it will eventually become obsolete.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/913
@parthchandra LGTM. There are questions that I have related to how travis-ci build is configured, but they are for pre-existing settings and can be addressed in a follow up PR if necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Posted by ilooner-mapr <gi...@git.apache.org>.
Github user ilooner-mapr commented on the issue:
https://github.com/apache/drill/pull/913
@vrozov I got it working with Trusty and explicitly configuring openjdk7. One thing to note is that Trusty was running out of memory doing the build with the default 4gb container size. So I had to add the **sudo: required** option in order to increase the vm size https://docs.travis-ci.com/user/reference/overview/ .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/913
@ilooner-mapr I tested it on my branch and it works with the default jdk and without *sudo*. Add `MAVEN_OPTS="-Xms1G -Xmx1G"` before `mvn`.
Can you remove leading dash from the commit message as part of rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Posted by ilooner-mapr <gi...@git.apache.org>.
Github user ilooner-mapr commented on the issue:
https://github.com/apache/drill/pull/913
@vrozov It looks like the default jdk for Trusty on travis is jdk8. I'll check to see if explicitly telling travis to use jdk7 with Trusty is also a possible fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Posted by ilooner-mapr <gi...@git.apache.org>.
Github user ilooner-mapr commented on the issue:
https://github.com/apache/drill/pull/913
@vrozov Spoke with Parth. Could you take a look at this PR? There are other issues with the travis build. For example it doesn't even run the unit tests right now. But this is a first step to fix what is currently in the travis build from failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Posted by parthchandra <gi...@git.apache.org>.
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/913
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/913#discussion_r135291374
--- Diff: .travis.yml ---
@@ -13,8 +13,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-sudo: false
before_install: git fetch --unshallow
language: java
-install: mvn install --batch-mode -DskipTests=true -Dmaven.javadoc.skip=true -Dsource.skip=true > mvn_install.log || (cat mvn_install.log && false)
-script: mvn package -DskipTests=true
+jdk:
+ - openjdk7
--- End diff --
@ilooner-mapr Switch to jdk7 is not required, it works with jdk8 as well, but enforcing jdk7 helps with validating that the project is java 1.7 compliant, so I am OK with the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Posted by ilooner-mapr <gi...@git.apache.org>.
Github user ilooner-mapr commented on the issue:
https://github.com/apache/drill/pull/913
@vrozov I've fixed the source.skip switch to be maven.source.skip as you pointed out. For now I also made the **script** tag a noop since as you said the mvn package command is redundant at this point. The **script** tag can't be completely removed because then travis runs its own default command for **script** which causes failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Posted by ilooner-mapr <gi...@git.apache.org>.
Github user ilooner-mapr commented on the issue:
https://github.com/apache/drill/pull/913
@parthchandra
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/913#discussion_r135143313
--- Diff: .travis.yml ---
@@ -13,8 +13,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-sudo: false
+sudo: required
before_install: git fetch --unshallow
language: java
+jdk:
+ - openjdk7
install: mvn install --batch-mode -DskipTests=true -Dmaven.javadoc.skip=true -Dsource.skip=true > mvn_install.log || (cat mvn_install.log && false)
--- End diff --
@ilooner-mapr can you remove redirection to mvn_install.log as part of the same PR. It is not necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/913#discussion_r135148431
--- Diff: .travis.yml ---
@@ -13,8 +13,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-sudo: false
+sudo: required
before_install: git fetch --unshallow
language: java
+jdk:
+ - openjdk7
install: mvn install --batch-mode -DskipTests=true -Dmaven.javadoc.skip=true -Dsource.skip=true > mvn_install.log || (cat mvn_install.log && false)
script: mvn package -DskipTests=true
--- End diff --
`install` includes `package` goal and I don't think that javadoc or source plugin are enabled in the default profile, so `script` just repeats the `install`. Also, if the goal is to skip source jar generation, the proper property is maven.source.skip, I believe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---