You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Dongjoon Hyun (JIRA)" <ji...@apache.org> on 2019/08/05 01:54:00 UTC
[jira] [Created] (SPARK-28616) Improve merge-spark-pr script to
warn WIP PRs and strip trailing dots
Dongjoon Hyun created SPARK-28616:
-------------------------------------
Summary: Improve merge-spark-pr script to warn WIP PRs and strip trailing dots
Key: SPARK-28616
URL: https://issues.apache.org/jira/browse/SPARK-28616
Project: Spark
Issue Type: Improvement
Components: Project Infra
Affects Versions: 3.0.0
Reporter: Dongjoon Hyun
This issue aims to improve the `merge-spark-pr` script.
- `[WIP]` is useful when we show that a PR is not ready for merge. Apache Spark allows merging `WIP` PRs. However, sometime, we accidentally forgot to clean up the title for the completed PRs. We had better warn once more during merging stage and get a confirmation from the committers.
- We have two kinds of PR title in terms of the ending period. This issue aims to remove the trailing `dot` since the shorter is the better in the PR title. Also, the PR titles without the trailing `dot` is dominant in the commit logs.
{code}
$ git log --oneline | grep '[.]$' | wc -l
4090
$ git log --oneline | grep '[^.]$' | wc -l
20747
{code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org