[GitHub] [cxf] reta commented on a change in pull request #805: Make CDI and MP Config dependencies optional for MicroProfile REST client

[GitBox <gi...@apache.org>]

reta commented on a change in pull request #805:
URL: https://github.com/apache/cxf/pull/805#discussion_r674762330



##########
File path: rt/rs/microprofile-client/pom.xml
##########
@@ -134,15 +134,20 @@
         <dependency>
             <groupId>org.eclipse.microprofile.config</groupId>
             <artifactId>microprofile-config-api</artifactId>
+            <scope>provided</scope>

Review comment:
       @brevilo @rmannibucau Guys, I think `<scope>provided</scope>` is redundant here,  `<optional>true</optional>` is suffice by all means. Why:
    - `<scope>provided</scope>` means that dependency is **required** and has to be provided at runtime [1]
    - `<optional>true</optional>` means dependency is **not required** but for some features only [2]
    
   [1] https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html
   [2] https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org