You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Henry Robinson (JIRA)" <ji...@apache.org> on 2009/06/09 13:34:07 UTC
[jira] Created: (ZOOKEEPER-441) Zk-336 diff got applied twice to
TestClientRetry.cc C test, causing compilation failure
Zk-336 diff got applied twice to TestClientRetry.cc C test, causing compilation failure
---------------------------------------------------------------------------------------
Key: ZOOKEEPER-441
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-441
Project: Zookeeper
Issue Type: Bug
Reporter: Henry Robinson
Assignee: Henry Robinson
Priority: Blocker
The latest version of trunk has a src/c/tests/TestClientRetry.cc file that has the actual file from ZK-336 appended to itself. This causes the compilation to fail due to lots of redeclaration errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-441) Zk-336 diff got applied twice to
TestClientRetry.cc C test, causing compilation failure
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717734#action_12717734 ]
Benjamin Reed commented on ZOOKEEPER-441:
-----------------------------------------
thanx henry! i had a rough night last night. i missed this one. testing now.
> Zk-336 diff got applied twice to TestClientRetry.cc C test, causing compilation failure
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-441
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-441
> Project: Zookeeper
> Issue Type: Bug
> Reporter: Henry Robinson
> Assignee: Henry Robinson
> Priority: Blocker
> Attachments: ZOOKEEPER-441.patch
>
>
> The latest version of trunk has a src/c/tests/TestClientRetry.cc file that has the actual file from ZK-336 appended to itself. This causes the compilation to fail due to lots of redeclaration errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-441) Zk-336 diff got applied twice to
TestClientRetry.cc C test, causing compilation failure
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson updated ZOOKEEPER-441:
-------------------------------------
Status: Patch Available (was: Open)
> Zk-336 diff got applied twice to TestClientRetry.cc C test, causing compilation failure
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-441
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-441
> Project: Zookeeper
> Issue Type: Bug
> Reporter: Henry Robinson
> Assignee: Henry Robinson
> Priority: Blocker
> Attachments: ZOOKEEPER-441.patch
>
>
> The latest version of trunk has a src/c/tests/TestClientRetry.cc file that has the actual file from ZK-336 appended to itself. This causes the compilation to fail due to lots of redeclaration errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-441) Zk-336 diff got applied twice to
TestClientRetry.cc C test, causing compilation failure
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson updated ZOOKEEPER-441:
-------------------------------------
Attachment: ZOOKEEPER-441.patch
Seems like the patch got applied twice - it's annoying that patch is not idempotent for file additions :) I'm not sure if this new patch is the right way to fix it, or if the committers should rollback and reapply ZK-336.
> Zk-336 diff got applied twice to TestClientRetry.cc C test, causing compilation failure
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-441
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-441
> Project: Zookeeper
> Issue Type: Bug
> Reporter: Henry Robinson
> Assignee: Henry Robinson
> Priority: Blocker
> Attachments: ZOOKEEPER-441.patch
>
>
> The latest version of trunk has a src/c/tests/TestClientRetry.cc file that has the actual file from ZK-336 appended to itself. This causes the compilation to fail due to lots of redeclaration errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-441) Zk-336 diff got applied twice to
TestClientRetry.cc C test, causing compilation failure
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-441:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
fixed! thanx henry!
> Zk-336 diff got applied twice to TestClientRetry.cc C test, causing compilation failure
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-441
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-441
> Project: Zookeeper
> Issue Type: Bug
> Reporter: Henry Robinson
> Assignee: Henry Robinson
> Priority: Blocker
> Attachments: ZOOKEEPER-441.patch
>
>
> The latest version of trunk has a src/c/tests/TestClientRetry.cc file that has the actual file from ZK-336 appended to itself. This causes the compilation to fail due to lots of redeclaration errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (ZOOKEEPER-441) Zk-336 diff got applied twice to
TestClientRetry.cc C test, causing compilation failure
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt closed ZOOKEEPER-441.
----------------------------------
> Zk-336 diff got applied twice to TestClientRetry.cc C test, causing compilation failure
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-441
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-441
> Project: Zookeeper
> Issue Type: Bug
> Reporter: Henry Robinson
> Assignee: Henry Robinson
> Priority: Blocker
> Attachments: ZOOKEEPER-441.patch
>
>
> The latest version of trunk has a src/c/tests/TestClientRetry.cc file that has the actual file from ZK-336 appended to itself. This causes the compilation to fail due to lots of redeclaration errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.