[jira] [Comment Edited] (MNG-7448) if we delete bin directory in apache-maven/src, we can not find because git has ignore it .

["Michael Osipov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17533728#comment-17533728 ] 

Michael Osipov edited comment on MNG-7448 at 5/9/22 9:48 AM:
-------------------------------------------------------------

I think we should just commit this and that's it:
{noformat}
$ git diff
diff --git a/.gitignore b/.gitignore
index 0a2cc2d71..69c3758e8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,12 +3,10 @@ target/
 .classpath
 .settings/
 .svn/
-bin/
 # Intellij
 *.ipr
 *.iml
 .idea
-out/
 .DS_Store
 /bootstrap
 /dependencies.xml
{noformat}

All current IDEs support Maven out of the box and the {{bin/}} is from ancient Eclipse times where the project was imported without Maven support. Eclipse produced a bin dir by default.


was (Author: michael-o):
I think we should just commit this and that's it:
{noformat}
$ git diff
diff --git a/.gitignore b/.gitignore
index 0a2cc2d71..69c3758e8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,12 +3,10 @@ target/
 .classpath
 .settings/
 .svn/
-bin/
 # Intellij
 *.ipr
 *.iml
 .idea
-out/
 .DS_Store
 /bootstrap
 /dependencies.xml
{noformat}

> if we delete bin directory in apache-maven/src, we can not find because git has ignore it .
> -------------------------------------------------------------------------------------------
>
>                 Key: MNG-7448
>                 URL: https://issues.apache.org/jira/browse/MNG-7448
>             Project: Maven
>          Issue Type: Improvement
>          Components: build/consumer
>    Affects Versions: 3.8.5
>            Reporter: Daqian Liao
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>         Attachments: bin.png, image-2022-05-06-20-32-09-746.png
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> when we download sourcecode, and push code to github, the apache-maven/src/bin directory will not be pushed.
> If we delete bin directory in apache-maven/src, we can not find because git has ignore it .
> The reason is that .gitignore file contains bin at line 6。
> fix: delete bin/ from .gitignore
> !bin.png!
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)