You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/24 18:39:16 UTC
[GitHub] [arrow] lidavidm opened a new pull request, #13696: ARROW-17191: [C++][FlightRPC] Handle inlined slices after concatenation
lidavidm opened a new pull request, #13696:
URL: https://github.com/apache/arrow/pull/13696
See the JIRA for details, but essentially: data was getting corrupted since allocating a new `shared_ptr` control block was overwriting the data in a `GrpcBuffer`. This happened because the data was inlined into the structure, which we weren't properly accounting for. Instead, copy the data into a new buffer in these cases.
I'm not sure why creating a new `shared_ptr` was overlapping an existing allocation, however.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13696: ARROW-17191: [C++][FlightRPC] Handle inlined slices after concatenation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13696:
URL: https://github.com/apache/arrow/pull/13696#issuecomment-1193371990
https://issues.apache.org/jira/browse/ARROW-17191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #13696: ARROW-17191: [C++][FlightRPC] Handle inlined slices after concatenation
Posted by GitBox <gi...@apache.org>.
kou merged PR #13696:
URL: https://github.com/apache/arrow/pull/13696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13696: ARROW-17191: [C++][FlightRPC] Handle inlined slices after concatenation
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13696:
URL: https://github.com/apache/arrow/pull/13696#issuecomment-1193575988
Benchmark runs are scheduled for baseline = 75ca3b21bc39ed91274aca7da57ee9328ae3c087 and contender = ef6049a2ee5673d0944a0b4f70ff9c70e0419a22. ef6049a2ee5673d0944a0b4f70ff9c70e0419a22 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/22f5f73515c0468bb6e3a648a03ab9d1...39112e352ebf4c668af40fee18f78dd4/)
[Failed :arrow_down:0.99% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5ae9ca691e6f4bd48898cc5bf05e533a...72fa46f9a90e406a9c27e236a13ef96b/)
[Finished :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/95fd13fc7a934660ab8c19722de01520...76630bfc9c074e2987cd3ca6f88e03c6/)
[Finished :arrow_down:0.46% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8756d978bba14cb0be9dba8036226aea...e6b46b018e534d398d4b6bcb48f3306d/)
Buildkite builds:
[Failed] [`ef6049a2` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1190)
[Finished] [`ef6049a2` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1202)
[Finished] [`ef6049a2` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1184)
[Finished] [`ef6049a2` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1204)
[Failed] [`75ca3b21` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1189)
[Failed] [`75ca3b21` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1201)
[Finished] [`75ca3b21` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1183)
[Finished] [`75ca3b21` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1203)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org