[GitHub] [apisix] Yiyiyimu commented on pull request #1943: feature: support etcd v3

[GitBox <gi...@apache.org>]

Yiyiyimu commented on pull request #1943:
URL: https://github.com/apache/apisix/pull/1943#issuecomment-667541535


   Feature implemented in this commit:
   - Change etcd version directly in config.yaml and core.lua would do the job to select etcd.lua and config_etcd.lua of a certain version. Thanks to @nic-chen's idea.
   - Trying to make the output of v2&v3 stay the same, so we don't need to make a copy of test files just a little bit different from each other. The main modification is inside [test_admin.t](https://github.com/apache/apisix/pull/1943/commits/ed38401f78a0305dba010a30c437ccad4bdc4037#diff-315ae794239f7ec737e9d6f7028fbcc5) for now. And I'm still in the middle of trying to modify each test file to make it compatible with both v2 and v3 output. I'm not so sure if there would be a more elegant way to implement this feature
   
   And another question hasn't been solved here is do we need multi-version of etcd? @moonming 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org