You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/16 16:06:18 UTC

[GitHub] [pulsar] BewareMyPower commented on pull request #15622: [Java Client] Fix wrong schema version of messages without schema

BewareMyPower commented on PR #15622:
URL: https://github.com/apache/pulsar/pull/15622#issuecomment-1127858468

   I'm not sure whether this fix should be cherry-picked to older branches since it changes the current behavior (even if I think it's correct).
   
   Since it's a fix at producer side, for messages produced by older version producer, even if they are compatible with the schema, the consumer still cannot consume them. In this PR, I also checked `schema.length == 0` in `MultiVersionSchemaInfoProvider#getSchemaByVersion`. However, it means if the changes of producer were reverted, the tests could still pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org