You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@harmony.apache.org by "George Harley (JIRA)" <ji...@apache.org> on 2006/06/27 22:25:30 UTC

[jira] Resolved: (HARMONY-675) [classlib][nio] Refactor ServerSocketAdapter.accept(Socket, SocketChannelImpl) in o.a.h.nio.internal.ServerSocketChannelImpl

     [ http://issues.apache.org/jira/browse/HARMONY-675?page=all ]
     
George Harley resolved HARMONY-675:
-----------------------------------

    Resolution: Fixed

Hi Andrew, 

Patch committed in revision 417579. Please could you check that it has been applied as expected. 

Best regards, 
George

> [classlib][nio]  Refactor  ServerSocketAdapter.accept(Socket, SocketChannelImpl) in o.a.h.nio.internal.ServerSocketChannelImpl
> ------------------------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-675
>          URL: http://issues.apache.org/jira/browse/HARMONY-675
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Andrew Zhang
>     Assignee: George Harley
>     Priority: Minor
>  Attachments: nio.diff
>
> There are serveral problems in ServerSocketAdapter.accept(Socket, SocketChannelImpl) method:
> 1. The modifier should be private, not public. As spec says: "The returned object will not declare any public methods that are not declared in the ServerSocket class."
> 2. One unnecessary FIXME.  
> 3. Some unneccessray code. 
> I'll upload a patch soon. Thanks!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira