You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by "James Taylor (JIRA)" <ji...@apache.org> on 2016/02/12 04:55:18 UTC

[jira] [Updated] (PHOENIX-2681) Avoid usage of HashSet in guideposts selection

     [ https://issues.apache.org/jira/browse/PHOENIX-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Taylor updated PHOENIX-2681:
----------------------------------
    Attachment: PHOENIX-2681.patch

Please review, [~tdsilva].

> Avoid usage of HashSet<byte[]> in guideposts selection
> ------------------------------------------------------
>
>                 Key: PHOENIX-2681
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2681
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>             Fix For: 4.7.0
>
>         Attachments: PHOENIX-2681.patch
>
>
> We use HashSet<byte[]> in our code to select which guideposts to use. It works because we luckily use the byte[] stored on the PTable consistently. It's possible that the array would be a different instance if the PTable was updated. In general, it's bad practice to use a HashSet with an array, so this updates that along with some other minor cleanup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)