(magpie) branch main updated: test(agent-isolation): keep the shim test's commit from signing (#1831)

[po...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/magpie.git


The following commit(s) were added to refs/heads/main by this push:
     new 9634e3e0e test(agent-isolation): keep the shim test's commit from signing (#1831)
9634e3e0e is described below

commit 9634e3e0ea319c2447b1d2c78308790850aa1e6e
Author: Jarek Potiuk <ja...@potiuk.com>
AuthorDate: Sun Oct 25 21:33:40 2026 +0100

    test(agent-isolation): keep the shim test's commit from signing (#1831)
    
    test_a_linked_worktree_targets_the_main_checkout makes one commit in a
    throwaway repository, which picked up the developer's global
    commit.gpgsign. With a hardware signing key the commit waited for a
    touch and then failed, so the test failed locally while passing in CI.
    The commit now runs with commit.gpgsign=false.
    
    Generated-by: Claude Opus 5
---
 tools/agent-isolation/tests/test_hook_manager_shim.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/agent-isolation/tests/test_hook_manager_shim.py b/tools/agent-isolation/tests/test_hook_manager_shim.py
index 43ea94d5a..c84b13517 100644
--- a/tools/agent-isolation/tests/test_hook_manager_shim.py
+++ b/tools/agent-isolation/tests/test_hook_manager_shim.py
@@ -73,8 +73,10 @@ def test_install_targets_the_common_git_dir(tmp_path: Path) -> None:
 def test_a_linked_worktree_targets_the_main_checkout(tmp_path: Path) -> None:
     env, argv = _setup(tmp_path)
     repo = _repo(tmp_path)
+    # A developer's global commit.gpgsign would make this commit wait for (or
+    # fail on) their signing key; the throwaway repo has nothing to sign.
     subprocess.run(
-        ["git", "-C", str(repo), "commit", "-q", "--allow-empty", "-m", "x"],
+        ["git", "-C", str(repo), "-c", "commit.gpgsign=false", "commit", "-q", "--allow-empty", "-m", "x"],
         check=True,
         env=dict(
             os.environ,