You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Dominic Hamon (JIRA)" <ji...@apache.org> on 2015/02/03 00:41:35 UTC

[jira] [Updated] (MESOS-2314) remove unnecessary constants

     [ https://issues.apache.org/jira/browse/MESOS-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dominic Hamon updated MESOS-2314:
---------------------------------
    Sprint: Twitter Mesos Q1 Sprint 2

> remove unnecessary constants
> ----------------------------
>
>                 Key: MESOS-2314
>                 URL: https://issues.apache.org/jira/browse/MESOS-2314
>             Project: Mesos
>          Issue Type: Improvement
>          Components: slave, technical debt
>            Reporter: Dominic Hamon
>            Assignee: Dominic Hamon
>            Priority: Minor
>              Labels: newbie
>
> In {{src/slave/paths.cpp}} a number of string constants are defined to describe the formats of various paths. However, given there is a 1:1 mapping between the string constant and the functions that build the paths, the code would be more readable if the format strings were inline in the functions.
> In the cases where one constant depends on another (see the {{EXECUTOR_INFO_PATH, EXECUTOR_PATH, FRAMEWORK_PATH, SLAVE_PATH, ROOT_PATH}} chain, for example) the function calls can just be chained together.
> This will have the added benefit of removing some statically constructed string constants, which are dangerous.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)