[GitHub] [geode] dschneider-pivotal commented on a change in pull request #6093: DRAFT: GEODE-9003: Remove the member from replicates as GII candidate if it'…

[GitBox <gi...@apache.org>]

dschneider-pivotal commented on a change in pull request #6093:
URL: https://github.com/apache/geode/pull/6093#discussion_r588600193



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/persistence/PersistenceAdvisorImpl.java
##########
@@ -533,7 +535,8 @@ public boolean checkMyStateOnMembers(Set<InternalDistributedMember> replicates)
         String message = String.format(
             "Region %s remote member %s with persistent data %s was not part of the same distributed system as the local data from %s",
             regionPath, member, remoteId, myId);
-        throw new ConflictingPersistentDataException(message);
+        logger.warn(message);

Review comment:
       A warning message will cause customers and support to think something is wrong. Is the user suppose to take same action based on this message? If you are correct that this is something geode will deal with automatically then at the most this should be an "info" message or "debug".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org