You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/09/15 04:43:50 UTC
[GitHub] [incubator-iotdb] zhanglingzhe0820 opened a new pull request #1735: Add wal test doc
zhanglingzhe0820 opened a new pull request #1735:
URL: https://github.com/apache/incubator-iotdb/pull/1735
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1735: [Doc]Add wal test doc
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #1735:
URL: https://github.com/apache/incubator-iotdb/pull/1735#discussion_r488384796
##########
File path: docs/zh/SystemDesign/StorageEngine/WAL.md
##########
@@ -21,6 +21,22 @@
# 写前日志
+## Work Process
+
Review comment:
* 对于每一个Memtable，都会记录一个 WAL 文件，当 Memtable 被 flush 完成时，WAL 会被删掉。
##########
File path: docs/zh/SystemDesign/StorageEngine/WAL.md
##########
@@ -21,6 +21,22 @@
# 写前日志
+## Work Process
Review comment:
```suggestion
## 工作流程
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin merged pull request #1735: [Doc]Add wal test doc
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #1735:
URL: https://github.com/apache/incubator-iotdb/pull/1735
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] zhanglingzhe0820 commented on a change in pull request #1735: [Doc]Add wal test doc
Posted by GitBox <gi...@apache.org>.
zhanglingzhe0820 commented on a change in pull request #1735:
URL: https://github.com/apache/incubator-iotdb/pull/1735#discussion_r488387832
##########
File path: docs/zh/SystemDesign/StorageEngine/WAL.md
##########
@@ -21,6 +21,22 @@
# 写前日志
+## Work Process
+
Review comment:
okay, I will add it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org